Remove auth0_app_token setting #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
commented
Mar 26, 2019
| $domain = $options->get( 'domain' ); | ||
|
|
||
| // Plugin version < 2.2.3 | ||
| if ( $this->current_db_version <= 7 ) { |
There was a problem hiding this comment.
No tenants reporting this version.
joshcanhelp
commented
Mar 26, 2019
| @@ -129,12 +129,6 @@ public function testConstantSettingNoticeBasic() { | |||
| 'render_function' => 'render_client_secret', | |||
| 'value' => rand(), | |||
| ], | |||
| [ | |||
There was a problem hiding this comment.
Not necessary to remove but the less references to this setting, the better.
joshcanhelp
commented
Mar 26, 2019
| @@ -24,41 +24,12 @@ public function check_update() { | |||
| } | |||
| } | |||
|
|
|||
| public function install_db( $version_to_install = null, $app_token = '' ) { | |||
There was a problem hiding this comment.
Not a breaking change, PHP does not report warnings/errors for extra function parameters
damieng
approved these changes
Mar 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR removes the API token field. All Management API interaction is handled by a client credentials grant.
Checklist