-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove auth0_app_token setting #641
Conversation
$domain = $options->get( 'domain' ); | ||
|
||
// Plugin version < 2.2.3 | ||
if ( $this->current_db_version <= 7 ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No tenants reporting this version.
@@ -129,12 +129,6 @@ public function testConstantSettingNoticeBasic() { | |||
'render_function' => 'render_client_secret', | |||
'value' => rand(), | |||
], | |||
[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessary to remove but the less references to this setting, the better.
@@ -24,41 +24,12 @@ public function check_update() { | |||
} | |||
} | |||
|
|||
public function install_db( $version_to_install = null, $app_token = '' ) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a breaking change, PHP does not report warnings/errors for extra function parameters
Changes
This PR removes the API token field. All Management API interaction is handled by a client credentials grant.
Checklist