-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combine all Lock-related settings on an Embedded tab #668
Conversation
@@ -65,30 +65,12 @@ public function init() { | |||
'id' => 'wpa0_default_login_redirection', | |||
'function' => 'render_default_login_redirection', | |||
), | |||
array( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these were moved to lib/admin/WP_Auth0_Admin_Appearance.php
@@ -253,10 +223,14 @@ public function render_default_login_redirection( $args = array() ) { | |||
* Render form field and description for the `lock_connections` option. | |||
* IMPORTANT: Internal callback use only, do not call this function directly! | |||
* | |||
* @deprecated - 3.10.0, moved to Features section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deprecating here, a deprecation PR for methods marked as internal seemed overkill.
), | ||
); | ||
$this->init_option_section( '', 'appearance', $options ); | ||
} | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these methods existed in the plugin already (see deprecated methods above).
); | ||
} | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of these methods existed in the plugin already (see deprecated methods above).
Changes
Note for reviewers: Ignore
languages/wp-auth0-es_ES.mo
,languages/wp-auth0-es_ES.po
, andlanguages/wp-auth0.pot
. All changes there appear in the code itself (strings and translations).