Combine all Lock-related settings on an Embedded tab #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
commented
Apr 9, 2019
| @@ -65,30 +65,12 @@ public function init() { | |||
| 'id' => 'wpa0_default_login_redirection', | |||
| 'function' => 'render_default_login_redirection', | |||
| ), | |||
| array( | |||
There was a problem hiding this comment.
All of these were moved to lib/admin/WP_Auth0_Admin_Appearance.php
joshcanhelp
commented
Apr 9, 2019
| @@ -253,10 +223,14 @@ public function render_default_login_redirection( $args = array() ) { | |||
| * Render form field and description for the `lock_connections` option. | |||
| * IMPORTANT: Internal callback use only, do not call this function directly! | |||
| * | |||
| * @deprecated - 3.10.0, moved to Features section. | |||
There was a problem hiding this comment.
Deprecating here, a deprecation PR for methods marked as internal seemed overkill.
joshcanhelp
commented
Apr 9, 2019
| ), | ||
| ); | ||
| $this->init_option_section( '', 'appearance', $options ); | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
All of these methods existed in the plugin already (see deprecated methods above).
joshcanhelp
commented
Apr 9, 2019
| ); | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
All of these methods existed in the plugin already (see deprecated methods above).
damieng
approved these changes
Apr 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Note for reviewers: Ignore
languages/wp-auth0-es_ES.mo,languages/wp-auth0-es_ES.po, andlanguages/wp-auth0.pot. All changes there appear in the code itself (strings and translations).