Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove small social icons #680

Merged
merged 3 commits into from
May 3, 2019
Merged

Remove small social icons #680

merged 3 commits into from
May 3, 2019

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented May 3, 2019 •
edited

Changes

  • Remove small social button option
  • Fix Embedded setting validation

References

Testing

  • This change adds unit test coverage
  • This change has been tested on WP 5.1.1

Checklist

  • All existing and new tests complete without errors
  • All code quality tools/guidelines in the Contribution guide have been run/followed
  • All active GitHub CI checks have passed

joshcanhelp
joshcanhelp commented May 3, 2019
View reviewed changes
WP_Auth0.php
@@ -9,8 +9,8 @@
* Text Domain: wp-auth0
*/

define( 'WPA0_VERSION', '3.10.0' );
define( 'AUTH0_DB_VERSION', 21 );
define( 'WPA0_VERSION', '3.11.0-beta' );
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set a plugin version that can be updated when the GA version is released

joshcanhelp
joshcanhelp commented May 3, 2019
View reviewed changes
lib/WP_Auth0_Lock10_Options.php
if ( $this->_is_valid( $settings, 'social_big_buttons' ) ) {
$options_obj['socialButtonStyle'] = $settings['social_big_buttons'] ? 'big' : 'small';
}
$options_obj['socialButtonStyle'] = 'big';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always set to big

@joshcanhelp joshcanhelp added this to the 3.11.0 milestone May 3, 2019
@joshcanhelp joshcanhelp requested a review from a team May 3, 2019 21:38
@joshcanhelp joshcanhelp marked this pull request as ready for review May 3, 2019 21:39
@joshcanhelp joshcanhelp merged commit bb5afbb into master May 3, 2019
@joshcanhelp joshcanhelp deleted the remove-small-social-icons branch May 3, 2019 22:00
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@damieng damieng damieng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.11.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshcanhelp @damieng