Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated from import settings #752

Merged
merged 2 commits into from
Dec 18, 2019
Merged

Remove deprecated from import settings #752

merged 2 commits into from
Dec 18, 2019

Conversation

joshcanhelp
Copy link
Contributor

@joshcanhelp joshcanhelp commented Dec 17, 2019 •
edited

Changes

  • Remove ability to upload an import JSON file to avoid potential security problems and additional site configuration (JSON files are not allowed by default in WP).
  • Move WP_Auth0_Import_Settings::init() actions to functions.
  • Remove WP_Auth0_Import_Settings::show_error()
  • Add explicit checks for admin capabilities on import and export settings pages.

Testing

  • This change adds unit test coverage
  • This change has been tested on WP 5.3

Checklist

  • All existing and new tests complete without errors
  • All code quality tools/guidelines in the Contribution guide have been run/followed
  • All active GitHub CI checks have passed

@joshcanhelp joshcanhelp added this to the 4.0.0 milestone Dec 17, 2019
@joshcanhelp joshcanhelp force-pushed the remove-deprecated-from-import-settings branch from 2ff4c52 to a910d50 Compare December 17, 2019 17:41
@joshcanhelp joshcanhelp marked this pull request as ready for review December 17, 2019 17:44
@joshcanhelp joshcanhelp requested a review from a team December 17, 2019 17:44
damieng
damieng reviewed Dec 17, 2019
View reviewed changes
WP_Auth0.php Outdated Show resolved Hide resolved
functions.php Show resolved Hide resolved
@joshcanhelp joshcanhelp mentioned this pull request Dec 18, 2019
Merged
5 tasks
damieng
damieng reviewed Dec 18, 2019
View reviewed changes
WP_Auth0.php Show resolved Hide resolved
@joshcanhelp joshcanhelp merged commit 9ce83b6 into master Dec 18, 2019
@joshcanhelp joshcanhelp deleted the remove-deprecated-from-import-settings branch December 18, 2019 19:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@damieng damieng damieng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshcanhelp @damieng