Remove deprecated from errorlog #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
force-pushed
the
remove-deprecated-from-errorlog
branch
from
d92092d
to
b4c867b
Compare
joshcanhelp
force-pushed
the
remove-deprecated-from-errorlog
branch
from
b4c867b
to
2735a7d
Compare
joshcanhelp
commented
Dec 18, 2019
| if ( empty( $_POST['nonce'] ) || ! wp_verify_nonce( $_POST['nonce'], 'clear_error_log' ) ) { | ||
| wp_die( __( 'Not allowed.', 'wp-auth0' ) ); | ||
| } | ||
| public static function insert_error( $section, $error ) { |
There was a problem hiding this comment.
Moved as-is from WP_Auth0_ErrorManager
joshcanhelp
commented
Dec 18, 2019
| * | ||
| * @hook admin_action_wpauth0_clear_error_log | ||
| */ | ||
| function wp_auth0_errorlog_clear_error_log() { |
There was a problem hiding this comment.
Moved here from WP_Auth0_ErrorLog
5 tasks
damieng
approved these changes
Dec 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
WP_Auth0_ErrorManager::insert_auth0_error()withWP_Auth0_ErrorLog::insert_error()WP_Auth0_ErrorManagerWP_Auth0_ErrorLog::init()Note to reviewers: Most of the changes here are moves from one file to another and re-naming.
Testing
Checklist