Remove deprecated from WP_Auth0_InitialSetup #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
force-pushed
the
remove-deprecated-from-initial-setup
branch
from
384c239
to
7e9b80b
Compare
joshcanhelp
changed the title
joshcanhelp
force-pushed
the
remove-deprecated-from-initial-setup
branch
from
1374097
to
39f7f03
Compare
joshcanhelp
commented
Dec 20, 2019
| @@ -38,7 +38,8 @@ | |||
| "phpcbf": "\"vendor/bin/phpcbf\"", | |||
| "phpcbf-tests": "\"vendor/bin/phpcbf\" --standard=phpcs-test-ruleset.xml -s ./tests/", | |||
| "sniffs": "\"vendor/bin/phpcs\" -e", | |||
| "test": "\"vendor/bin/phpunit\" --coverage-text", | |||
| "test": "\"vendor/bin/phpunit\"", | |||
| "test-cov": "\"vendor/bin/phpunit\" --coverage-text", | |||
There was a problem hiding this comment.
Added this command to check coverage, default one does not (to speed up the checks).
joshcanhelp
commented
Dec 20, 2019
| <p> | ||
| <strong> | ||
| <?php echo __( 'There was an error creating the necessary client grants. ', 'wp-auth0' ); ?> | ||
| <?php _e( 'There was an error creating the necessary client grants. ', 'wp-auth0' ); ?> |
There was a problem hiding this comment.
echo __() is equivalent to _e()
joshcanhelp
commented
Dec 20, 2019
| <a href="https://manage.auth0.com">https://manage.auth0.com</a> | ||
| </strong> | ||
| </p> | ||
| </div> | ||
| <?php | ||
| } | ||
|
|
||
| public function init_setup() { |
There was a problem hiding this comment.
Moved to wp_auth0_initial_setup_init()
joshcanhelp
commented
Dec 20, 2019
| * | ||
| * @codeCoverageIgnore - Deprecated. | ||
| */ | ||
| public function init() { |
There was a problem hiding this comment.
Logic moved to wp_auth0_setup_error_admin_notices()
jimmyjames
suggested changes
Dec 20, 2019
joshcanhelp
force-pushed
the
remove-deprecated-from-initial-setup
branch
from
c9256d1
to
70271f7
Compare
jimmyjames
approved these changes
Dec 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
WP_Auth0_InitialSetup::init()towp_auth0_setup_error_admin_notices()WP_Auth0_InitialSetup::init_setup()towp_auth0_initial_setup_init()WP_Auth0_InitialSetuperror messageswpa0to setup pagewpa0-setupTesting
Checklist