Add settings validation to import #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshcanhelp
force-pushed
the
add-settings-validation-to-import
branch
2 times, most recently
from
83a29ab
to
0216fd4
Compare
joshcanhelp
commented
Feb 3, 2020
| @@ -73,7 +73,9 @@ public function init_admin() { | |||
| register_setting( | |||
| $this->a0_options->get_options_name() . '_basic', | |||
| $this->a0_options->get_options_name(), | |||
| [ $this, 'input_validator' ] | |||
| [ | |||
There was a problem hiding this comment.
Third argument as a callable was a backwards-compatible change. Now accepts an array:
https://developer.wordpress.org/reference/functions/register_setting/
joshcanhelp
force-pushed
the
add-settings-validation-to-import
branch
2 times, most recently
from
1afee68
to
2a9117d
Compare
joshcanhelp
force-pushed
the
add-settings-validation-to-import
branch
from
2a9117d
to
2142081
Compare
jimmyjames
approved these changes
Feb 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
WP_Auth0_Admin_Advanced->basic_validation()WP_Auth0_Admin_Advanced->migration_ws_validation()WP_Auth0_Admin_Advanced->migration_ips_validation()WP_Auth0_Admin_Appearance->basic_validation()WP_Auth0_Admin_Basic->basic_validation()WP_Auth0_Admin_Features->basic_validation()WP_Auth0_Admin_Advanced::loginredirection_validation()toWP_Auth0_Admin_Advanced->validate_login_redirect()and changed the signature to accept the new and previous values instead of arrays.Note to reviewers: vast majority of the changes here are renaming and changing the method signatures.
Testing
Checklist
master