Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(commands): totp qr code in png format #2673

Merged
merged 26 commits into from
Mar 2, 2022

Conversation

james-d-elliott
Copy link
Member

This allows exporting the TOTP QR code for easy registration when using authelia storage totp generate or authelia storage totp export.

This allows exporting the TOTP QR code for easy registration when using `authelia storage totp generate` or `authelia storage totp export`.
@authelia
Copy link

authelia bot commented Dec 4, 2021

Artifacts

These changes are published for testing on Buildkite, DockerHub and GitHub Container Registry.

Docker Container

  • docker pull authelia/authelia:feat-cmd-totp-qr-code
  • docker pull ghcr.io/authelia/authelia:feat-cmd-totp-qr-code

internal/commands/storage_run.go Outdated Show resolved Hide resolved
internal/commands/storage_run.go Outdated Show resolved Hide resolved
@james-d-elliott james-d-elliott marked this pull request as draft December 4, 2021 01:27
@james-d-elliott
Copy link
Member Author

Converting to draft. Will be merged as part of our next feature release cycle. People can still use the binary for executing the command.

@james-d-elliott james-d-elliott marked this pull request as ready for review January 27, 2022 00:06
@james-d-elliott james-d-elliott added the status/needs-review Pull requests that need to be reviewed label Feb 17, 2022
@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #2673 (ecdc52e) into master (6276883) will decrease coverage by 0.03%.
The diff coverage is 49.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2673      +/-   ##
==========================================
- Coverage   64.37%   64.33%   -0.04%     
==========================================
  Files         217      217              
  Lines       10935    11003      +68     
  Branches      278      278              
==========================================
+ Hits         7039     7079      +40     
- Misses       3393     3413      +20     
- Partials      503      511       +8     
Flag Coverage Δ
backend 68.08% <49.63%> (-0.07%) ⬇️
frontend 41.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/commands/storage_run.go 57.93% <47.61%> (-2.35%) ⬇️
internal/models/totp_configuration.go 88.00% <66.66%> (-12.00%) ⬇️
internal/commands/storage.go 100.00% <100.00%> (ø)
internal/ntp/util.go 88.46% <0.00%> (+11.53%) ⬆️
internal/middlewares/strip_path.go 100.00% <0.00%> (+54.54%) ⬆️

@james-d-elliott james-d-elliott removed the status/needs-review Pull requests that need to be reviewed label Mar 2, 2022
@james-d-elliott james-d-elliott merged commit 1b2af90 into master Mar 2, 2022
@james-d-elliott james-d-elliott deleted the feat-cmd-totp-qr-code branch March 2, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants