Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(configuration): missing warning about session domain #4417

Merged
merged 6 commits into from Nov 23, 2022

Conversation

james-d-elliott
Copy link
Member

No description provided.

@authelia
Copy link

authelia bot commented Nov 22, 2022

Artifacts

These changes are published for testing on Buildkite, DockerHub and GitHub Container Registry.

Docker Container

  • docker pull authelia/authelia:fix-show-warning-on-domain-prefix
  • docker pull ghcr.io/authelia/authelia:fix-show-warning-on-domain-prefix

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #4417 (e4139f6) into master (b295bf5) will increase coverage by 0.12%.
The diff coverage is 98.97%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4417      +/-   ##
==========================================
+ Coverage   66.83%   66.95%   +0.12%     
==========================================
  Files         266      266              
  Lines       18593    18604      +11     
  Branches      431      431              
==========================================
+ Hits        12426    12456      +30     
+ Misses       5428     5415      -13     
+ Partials      739      733       -6     
Flag Coverage Δ
backend 67.32% <98.97%> (+0.13%) ⬆️
frontend 62.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rnal/configuration/validator/identity_providers.go 98.74% <98.85%> (+2.96%) ⬆️
internal/configuration/validator/access_control.go 100.00% <100.00%> (ø)
internal/configuration/validator/session.go 100.00% <100.00%> (ø)
internal/commands/root.go 39.30% <0.00%> (+1.31%) ⬆️
internal/ntp/util.go 88.46% <0.00%> (+11.53%) ⬆️
internal/duo/duo.go 62.50% <0.00%> (+12.50%) ⬆️

@netlify
Copy link

netlify bot commented Nov 23, 2022

Deploy Preview for authelia-staging ready!

Name Link
🔨 Latest commit e9fedb1
🔍 Latest deploy log https://app.netlify.com/sites/authelia-staging/deploys/637dfe309357bb000995c7d1
😎 Deploy Preview https://deploy-preview-4417--authelia-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Nov 23, 2022

Deploy Preview for authelia-staging ready!

Name Link
🔨 Latest commit 37955db
🔍 Latest deploy log https://app.netlify.com/sites/authelia-staging/deploys/637dfe4e07235a00099bec03
😎 Deploy Preview https://deploy-preview-4417--authelia-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@james-d-elliott james-d-elliott merged commit 203cb19 into master Nov 23, 2022
@james-d-elliott james-d-elliott deleted the fix-show-warning-on-domain-prefix branch November 23, 2022 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant