feat(oidc): jwt response for introspection #5840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtifactsThese changes are published for testing on Buildkite, DockerHub and GitHub Container Registry. Docker Container
|
✅ Deploy Preview for authelia-staging ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
james-d-elliott
force-pushed
the
feat-jwt-response-for-introspection
branch
2 times, most recently
from
c2d624f
to
c289662
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5840 +/- ##
==========================================
+ Coverage 73.03% 73.51% +0.47%
==========================================
Files 280 281 +1
Lines 23742 24056 +314
Branches 443 443
==========================================
+ Hits 17341 17685 +344
+ Misses 5657 5630 -27
+ Partials 744 741 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
james-d-elliott
force-pushed
the
feat-jwt-response-for-introspection
branch
3 times, most recently
from
3e0a29c
to
b8b6168
Compare
autheliabot
reviewed
Aug 19, 2023
james-d-elliott
force-pushed
the
feat-jwt-response-for-introspection
branch
from
b8b6168
to
52aa15e
Compare
autheliabot
reviewed
Aug 19, 2023
james-d-elliott
force-pushed
the
feat-jwt-response-for-introspection
branch
5 times, most recently
from
de2f7b8
to
3f056d1
Compare
james-d-elliott
added
the
area/openid-connect
james-d-elliott
force-pushed
the
feat-jwt-response-for-introspection
branch
7 times, most recently
from
f0f098d
to
2f380e1
Compare
nightah
requested changes
Aug 25, 2023
docs/content/en/configuration/identity-providers/openid-connect/clients.md
Outdated
Show resolved
Hide resolved
docs/content/en/configuration/identity-providers/openid-connect/clients.md
Outdated
Show resolved
Hide resolved
| content: | ||
| application/json: | ||
| schema: | ||
| $ref: '#/components/schemas/openid.spec.ErrorResponseGeneric' |
There was a problem hiding this comment.
Does this cause a rendering issue with the OpenAPI spec?
This implements the standard for JWT encoded and signed responses from the introspection endpoint. This has been implemented as per the IETF draft https://www.ietf.org/archive/id/draft-ietf-oauth-jwt-introspection-response-12.html and as it is a draft and that draft is currently expired it should be noted that this implementation may be removed or changed without any regard for breaking changes. While these factors all point in the direction of this may never receive ratification the IANA has accepted registration of the metadata parameters for this specification. Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
james-d-elliott
force-pushed
the
feat-jwt-response-for-introspection
branch
from
2f380e1
to
047a1ca
Compare
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
james-d-elliott
force-pushed
the
feat-jwt-response-for-introspection
branch
from
757c5d5
to
8c98fdd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the standard for JWT encoded and signed responses from the introspection endpoint. This has been implemented as per the IETF draft https://datatracker.ietf.org/doc/html/draft-ietf-oauth-jwt-introspection-response and as it is a draft (it is also an expired draft) so it should be noted that this implementation may be removed or changed without any regard for breaking changes. While this factor points in the direction of this never receiving ratification the IANA has accepted registration of the metadata parameters for this specification which points to the fact that it probably will.