Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Allow Authelia to listen on a specified path #1027

Merged
merged 19 commits into from May 21, 2020
Merged

[FEATURE] Allow Authelia to listen on a specified path #1027

merged 19 commits into from May 21, 2020

Conversation

james-d-elliott
Copy link
Member

No description provided.

@authelia
Copy link

authelia bot commented May 18, 2020

Artifacts

These changes are published for testing on Buildkite and DockerHub.

Docker Container

  • docker pull authelia/authelia:feature-support-subpath

@nightah nightah requested a review from clems4ever May 19, 2020 03:10
@nightah nightah marked this pull request as ready for review May 19, 2020 03:10
@nightah
Copy link
Member

nightah commented May 19, 2020

Note: This will need some changes to the AUR packages too, so should be merged when the changes are ready to be deployed.

@nightah nightah added this to the v4.19.0 milestone May 19, 2020
nightah
nightah reviewed May 19, 2020
View reviewed changes
Copy link
Member

@nightah nightah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change to be adjusted post feedback.

internal/configuration/validator/server_test.go Outdated Show resolved Hide resolved
clems4ever
clems4ever requested changes May 19, 2020
View reviewed changes
internal/configuration/validator/server.go Show resolved Hide resolved
internal/server/index.go Outdated Show resolved Hide resolved
internal/utils/strings.go Outdated Show resolved Hide resolved
internal/middlewares/strip_path.go Show resolved Hide resolved
@clems4ever
Copy link
Member

you should check branch feature-support-subpath2 to see how to use the tag attribute method and consequently avoid the unwanted CSP attributes and the type casting. There was also an issue with the dev workflow that I fixed in my branch by setting REACT_APP_BASEPATH env vars in dev and production config files.

@nightah
Update CSP
e644d29
@nightah
Fix unit test
43de5ce 
Also remove check for body as this will never get triggered, react itself is loaded inside the body so this has to always be successful.
@nightah
Template index.html with ${PUBLIC_URL}
50b350b
@nightah
Define PUBLIC_URL in .env(s)
f35c60e
clems4ever
clems4ever reviewed May 20, 2020
View reviewed changes
config.template.yml Outdated Show resolved Hide resolved
clems4ever
clems4ever previously requested changes May 20, 2020
View reviewed changes
Copy link
Member

@clems4ever clems4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final suggestion on the comment around the path configuration. Otherwise LGTM.

@nightah nightah merged commit fcd0b5e into master May 21, 2020
@nightah nightah deleted the feature-support-subpath branch May 21, 2020 02:20
@clems4ever clems4ever mentioned this pull request Jun 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nightah nightah nightah approved these changes

@clems4ever clems4ever clems4ever left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.19.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@james-d-elliott @nightah @clems4ever