[MISC] Catch OpenLDAP ppolicy error #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtifactsThese changes are published for testing on Buildkite and DockerHub. Docker Container
|
Codecov Report
@@ Coverage Diff @@
## master #1508 +/- ##
==========================================
+ Coverage 66.75% 66.79% +0.04%
==========================================
Files 144 144
Lines 3976 3981 +5
Branches 169 169
==========================================
+ Hits 2654 2659 +5
Misses 1113 1113
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more.
|
james-d-elliott
previously requested changes
Dec 3, 2020
nightah
commented
Dec 8, 2020
clems4ever
previously requested changes
Dec 14, 2020
Further to the discussion over at #361, this change now ensures that OpenLDAP password complexity errors are caught and appropriately handled. This change also includes the PasswordComplexity test suite in the LDAP integration suite. This is because a ppolicy has been setup and enforced.
nightah
force-pushed
the
misc-openldap-ppolicy-support
branch
from
0ec0c5d
to
7a08cf5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further to the discussion over at #361, this change now ensures that OpenLDAP password complexity errors are caught and appropriately handled.
This change also includes the PasswordComplexity test suite in the LDAP integration suite. This is because a ppolicy has been setup and enforced.