-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MISC] Refactor and address most errcheck linter ignores #1511
Conversation
ArtifactsThese changes are published for testing on Buildkite and DockerHub. Docker Container
|
fdae29f
to
1c3bf14
Compare
Codecov Report
@@ Coverage Diff @@
## master #1511 +/- ##
==========================================
- Coverage 66.79% 66.34% -0.46%
==========================================
Files 144 144
Lines 3981 4005 +24
Branches 169 169
==========================================
- Hits 2659 2657 -2
- Misses 1113 1129 +16
- Partials 209 219 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a few comments but I'm ok for merging it like this since it already improves the situation a lot.
This is mostly a quality of life change. When we first implemented the errcheck linter we ignored a number of items in our legacy codebase with intent to revisit down the track.
e6824b6
to
15646c4
Compare
This is mostly a quality of life change.
When we first implemented the errcheck linter we ignored a number of items in our legacy codebase with intent to revisit down the track.
There's a only a few leftover TODO's, these have been left for the team to discuss on Matrix and agree on the way forward.