Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Add linting option for frontend and enforce styling #1565

Merged
merged 1 commit into from
Jan 2, 2021

Conversation

nightah
Copy link
Member

@nightah nightah commented Dec 29, 2020

We now extend the default React Eslint configuration and enforce styling with prettier for all of our frontend code.

An example of the linter output can be found here.

@authelia
Copy link

authelia bot commented Dec 29, 2020

Artifacts

These changes are published for testing on Buildkite and DockerHub.

Docker Container

  • docker pull authelia/authelia:ci-add-ts-linting

@codecov
Copy link

codecov bot commented Dec 29, 2020

Codecov Report

Merging #1565 (f8636f7) into master (a5ea31e) will decrease coverage by 0.04%.
The diff coverage is 63.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1565      +/-   ##
==========================================
- Coverage   66.12%   66.07%   -0.05%     
==========================================
  Files         144      144              
  Lines        4012     4015       +3     
  Branches      171      168       -3     
==========================================
  Hits         2653     2653              
- Misses       1140     1143       +3     
  Partials      219      219              
Flag Coverage Δ
backend 66.68% <ø> (ø)
frontend 63.85% <63.39%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
web/src/App.tsx 100.00% <ø> (ø)
web/src/Routes.ts 100.00% <ø> (ø)
web/src/components/AppStoreBadges.tsx 100.00% <ø> (ø)
web/src/components/PieChartIcon.tsx 100.00% <ø> (ø)
web/src/constants.ts 100.00% <ø> (ø)
web/src/hooks/Configuration.ts 100.00% <ø> (ø)
web/src/hooks/RedirectionURL.ts 100.00% <ø> (ø)
web/src/hooks/State.ts 100.00% <ø> (ø)
web/src/hooks/Timer.ts 0.00% <0.00%> (ø)
web/src/hooks/UserInfo.ts 100.00% <ø> (ø)
... and 59 more

@nightah nightah force-pushed the ci-add-ts-linting branch 2 times, most recently from 0b1d7f8 to efe9f85 Compare January 2, 2021 05:13
We now extend the default Eslint configuration and enforce styling with prettier for all of our frontend code.
Copy link
Member

@james-d-elliott james-d-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@james-d-elliott james-d-elliott merged commit 689fd7c into master Jan 2, 2021
@james-d-elliott james-d-elliott deleted the ci-add-ts-linting branch January 2, 2021 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants