refactor(suites): simplify kubernetes suite #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR achieves the following goals: * Utilise upstream version of kind instead of a patched version which allows binding to networks other than the default "kind" * Utilises the registry cache which is setup one level above the kind cluster The former point was required to successfully run our integration tests in a Kubernetes environment, however this is now possible without running a patched version of kind. The second point is because DockerHub has introduced rate limiting for container downloads. If there are a large number of CI jobs nodes may occasionally be rejected due to the Kubernetes suite not pulling down from the registry cache.
ArtifactsThese changes are published for testing on Buildkite and DockerHub. Docker Container
|
Codecov Report
@@ Coverage Diff @@
## master #1680 +/- ##
=======================================
Coverage 70.16% 70.16%
=======================================
Files 149 149
Lines 4130 4130
Branches 172 172
=======================================
Hits 2898 2898
Misses 1001 1001
Partials 231 231
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR achieves the following goals:
The former point was required to successfully run our integration tests in a Kubernetes environment, however this is now possible without running a patched version of kind.
The second point is because DockerHub has introduced rate limiting for container downloads. If there are a large number of CI jobs nodes may occasionally be rejected due to the Kubernetes suite not pulling down from the registry cache.