Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: redis sentinel secret missing #1839

Merged
merged 10 commits into from
Mar 22, 2021

Conversation

james-d-elliott
Copy link
Member

Adds the redis sentinel secret and refactors the entire secret derivation process to make it more consistent.

Adds the redis sentinel secret and refactors the entire secret derivation process to make it more consistent.
@authelia
Copy link

authelia bot commented Mar 18, 2021

Artifacts

These changes are published for testing on Buildkite and DockerHub.

Docker Container

  • docker pull authelia/authelia:fix-redis-sentinel-password-secret

@codecov
Copy link

codecov bot commented Mar 18, 2021

Codecov Report

Merging #1839 (693657f) into master (7ccbaaf) will increase coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1839      +/-   ##
==========================================
+ Coverage   71.80%   71.99%   +0.18%     
==========================================
  Files         152      152              
  Lines        4313     4313              
  Branches      177      177              
==========================================
+ Hits         3097     3105       +8     
+ Misses        991      985       -6     
+ Partials      225      223       -2     
Flag Coverage Δ
backend 73.75% <100.00%> (+0.11%) ⬆️
frontend 65.20% <ø> (+0.44%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/configuration/validator/authentication.go 100.00% <ø> (+2.98%) ⬆️
internal/configuration/validator/configuration.go 100.00% <ø> (ø)
internal/configuration/reader.go 95.00% <100.00%> (-0.75%) ⬇️
internal/configuration/validator/keys.go 100.00% <100.00%> (ø)
internal/configuration/validator/secrets.go 84.37% <100.00%> (+4.37%) ⬆️
internal/configuration/validator/storage.go 100.00% <100.00%> (ø)
web/src/hooks/IntermittentClass.ts 76.47% <0.00%> (+23.52%) ⬆️

Also adjust tests for windows env compat.
@james-d-elliott james-d-elliott force-pushed the fix-redis-sentinel-password-secret branch from fae7c1b to 091e88e Compare March 18, 2021 07:57
@james-d-elliott james-d-elliott merged commit a44f0cf into master Mar 22, 2021
@james-d-elliott james-d-elliott deleted the fix-redis-sentinel-password-secret branch March 22, 2021 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants