fix: removed deprecated smtp/ldap options #1912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the deprecated options from 4.25. This includes the LDAP filters which allow {0} or {1} placeholders. The new aliases are documented. Additionally it refactors the keys validator to use uniform messages for most replaced keys.
ArtifactsThese changes are published for testing on Buildkite, DockerHub and GitHub Container Registry. Docker Container
|
Codecov Report
@@ Coverage Diff @@
## master #1912 +/- ##
==========================================
- Coverage 72.08% 71.86% -0.22%
==========================================
Files 152 152
Lines 4345 4319 -26
Branches 179 179
==========================================
- Hits 3132 3104 -28
- Misses 991 995 +4
+ Partials 222 220 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
james-d-elliott
changed the title
nightah
previously requested changes
Apr 15, 2021
james-d-elliott
force-pushed
the
refactor-remove-deprecated
branch
from
c8fbc42
to
dfee0bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the deprecated options from 4.25. This includes the LDAP filters which allow {0} or {1} placeholders. The new aliases are documented. Additionally it refactors the keys validator to use uniform messages for most replaced keys.
Fix because they should have been removed in 4.28.0, but will be removed in 4.28.1 instead. Also it's noteworthy that the coverage has decreased, it appears it's because there were a lot of previously covered lines completely removed mostly. I couldn't see any other negative hits though if you see one let me know.