[FIX] Fix default redirection URL not taken into account #600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clems4ever
force-pushed
the
fix-default-redirect
branch
from
c9c4622
to
d70cdb0
Compare
clems4ever
changed the title
clems4ever
requested review from
james-d-elliott and
nightah
and removed request for
james-d-elliott
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default redirection URL was not taken into account in v4. I took the opportunity to add unit tests in every 2FA options and integration tests in 2 suites testing TOTP and Duo.
We don't have any U2F oriented suite so the feature is not tested in integration but I think it's fine given the code handling the redirection is now shared across the 2FA methods and there are unit tests for every methods.