Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Document usage of env variables for setting secrets. #606

Merged
merged 2 commits into from
Feb 1, 2020

Conversation

clems4ever
Copy link
Member

@clems4ever clems4ever commented Feb 1, 2020

This PR fixes: #579

@clems4ever clems4ever force-pushed the doc-env-var-secret branch 2 times, most recently from 5d5dd45 to 5b94a25 Compare February 1, 2020 11:54
Copy link
Member

@nightah nightah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the instances of could to can and then this LGTM.

config.template.yml Outdated Show resolved Hide resolved
Copy link
Member

@nightah nightah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nightah nightah merged commit 7f19078 into master Feb 1, 2020
@nightah nightah deleted the doc-env-var-secret branch February 1, 2020 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document secret configuration via environment variables
2 participants