-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(logging): only include stacktrace above info #7137
Conversation
ArtifactsThese changes are published for testing on Buildkite, DockerHub and GitHub Container Registry. Docker Container
|
WalkthroughThe recent updates aim to enhance the logging system by integrating Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
ccb9614
to
799bc4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
|
||
logrus.SetLevel(logrus.InfoLevel) | ||
} | ||
logrus.SetLevel(LogLevel(level).Level()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The simplification in the setLevelStr
function improves readability and maintainability. However, consider removing the unnecessary leading newline at line 38 to adhere to Go coding standards.
-
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
logrus.SetLevel(LogLevel(level).Level()) | |
logrus.SetLevel(LogLevel(level).Level()) |
799bc4c
to
4364dcb
Compare
This ensures the stacktrace is only included when the log level is configured above info, for example debug/trace. Signed-off-by: James Elliott <james-d-elliott@users.noreply.github.com>
4364dcb
to
0dca954
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7137 +/- ##
==========================================
- Coverage 73.68% 73.66% -0.02%
==========================================
Files 344 345 +1
Lines 29937 29962 +25
Branches 839 839
==========================================
+ Hits 22059 22073 +14
- Misses 7007 7018 +11
Partials 871 871
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This ensures the stacktrace is only included when the log level is configured above info, for example debug/trace.