Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MISC] Ignore errcheck recommendations for legacy code #893

Merged
merged 2 commits into from
Apr 22, 2020

Conversation

nightah
Copy link
Member

@nightah nightah commented Apr 21, 2020

Some of this is likely intended to stay how it is, some could use refactoring, for now we will mark it and ignore it from the linter, to be potentially addressed in the future.

Some of this is likely intended to stay how it is, some could use refactoring, for now we will mark is and ignore it from the linter to be potentially addressed in the future.
@authelia
Copy link

authelia bot commented Apr 21, 2020

Artifacts

These changes are published for testing on Buildkite and DockerHub.

Docker Container

  • docker pull authelia/authelia:misc-errcheck-linter

Copy link
Member

@james-d-elliott james-d-elliott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nightah nightah merged commit 54694c4 into master Apr 22, 2020
@nightah nightah deleted the misc-errcheck-linter branch April 22, 2020 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants