Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Enable gosec linter #979

Merged
merged 6 commits into from May 5, 2020
Merged

[CI] Enable gosec linter #979

merged 6 commits into from May 5, 2020

Conversation

james-d-elliott
Copy link
Member

No description provided.

@authelia
Copy link

authelia bot commented May 5, 2020

Artifacts

These changes are published for testing on Buildkite and DockerHub.

Docker Container

  • docker pull authelia/authelia:ci-gosec

autheliabot
autheliabot reviewed May 5, 2020
View reviewed changes
Copy link
Collaborator

@autheliabot autheliabot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

golangci

internal/storage/sqlite_provider.go|38 col 147| directive //nolint:gosec // Isn't actually a G201 issue. is unused for linter gosec (nolintlint)
internal/storage/sqlite_provider.go|39 col 147| directive //nolint:gosec // Isn't actually a G201 issue. is unused for linter gosec (nolintlint)
internal/storage/sqlite_provider.go|40 col 147| directive //nolint:gosec // Isn't actually a G201 issue. is unused for linter gosec (nolintlint)
internal/storage/sqlite_provider.go|42 col 119| directive //nolint:gosec // Isn't actually a G201 issue. is unused for linter gosec (nolintlint)
internal/storage/sqlite_provider.go|43 col 119| directive //nolint:gosec // Isn't actually a G201 issue. is unused for linter gosec (nolintlint)
internal/storage/sqlite_provider.go|44 col 119| directive //nolint:gosec // Isn't actually a G201 issue. is unused for linter gosec (nolintlint)
internal/storage/sqlite_provider.go|46 col 146| directive //nolint:gosec // Isn't actually a G201 issue. is unused for linter gosec (nolintlint)
internal/storage/sqlite_provider.go|47 col 146| directive //nolint:gosec // Isn't actually a G201 issue. is unused for linter gosec (nolintlint)
internal/storage/sqlite_provider.go|49 col 160| directive //nolint:gosec // Isn't actually a G201 issue. is unused for linter gosec (nolintlint)
internal/storage/sqlite_provider.go|50 col 160| directive //nolint:gosec // Isn't actually a G201 issue. is unused for linter gosec (nolintlint)

internal/storage/mysql_provider.go Outdated Show resolved Hide resolved
internal/storage/mysql_provider.go Outdated Show resolved Hide resolved
internal/storage/mysql_provider.go Outdated Show resolved Hide resolved
internal/storage/mysql_provider.go Outdated Show resolved Hide resolved
internal/storage/mysql_provider.go Outdated Show resolved Hide resolved
internal/storage/postgres_provider.go Outdated Show resolved Hide resolved
internal/storage/sqlite_provider.go Outdated Show resolved Hide resolved
internal/storage/sqlite_provider.go Outdated Show resolved Hide resolved
internal/storage/sqlite_provider.go Outdated Show resolved Hide resolved
internal/storage/sqlite_provider.go Outdated Show resolved Hide resolved
nightah
nightah approved these changes May 5, 2020
View reviewed changes
Copy link
Member

@nightah nightah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@james-d-elliott james-d-elliott merged commit c13196a into master May 5, 2020
@james-d-elliott james-d-elliott deleted the ci-gosec branch May 5, 2020 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@autheliabot autheliabot autheliabot left review comments

@nightah nightah nightah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@james-d-elliott @nightah @autheliabot