Linting and deprecation fixes #234
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arguments (super-with-arguments)
…om bases in python3 (useless-object-inheritance).
… (use-dict-literal)
…-variable) (noted in #34 but never patched).
…ds (chained-comparison).
jensens
approved these changes
May 30, 2024
| @@ -765,8 +762,7 @@ def valid(self): | |||
|
|
|||
| if self.expiration_time: | |||
| return self.expiration_time > int(time.time()) | |||
| else: | |||
| return True | |||
| return True | |||
There was a problem hiding this comment.
Even simpler:
return self.expiration_time and self.expiration_time > int(time.time())| @@ -783,8 +779,7 @@ def expire_soon(self, seconds): | |||
|
|
|||
| if self.expiration_time: | |||
| return self.expiration_time < int(time.time()) + int(seconds) | |||
| else: | |||
| return False | |||
| return False | |||
There was a problem hiding this comment.
Same here:
return self.expiration_time and self.expiration_time < int(time.time()) + int(seconds)
cstrap
reviewed
Jun 17, 2024
Comment on lines
+53
to
+54
| return {[(k, v[0] if not isinstance(v, str) and len(v) == 1 else v) | ||
| for k, v in list(dict_.items())]} |
There was a problem hiding this comment.
I think it could be rewritten like this:
Suggested change
| return {[(k, v[0] if not isinstance(v, str) and len(v) == 1 else v) | |
| for k, v in list(dict_.items())]} | |
| return {k: v[0] if not isinstance(v, str) and len(v) == 1 else v for k, v in dict_.items()} |
|
|
||
|
|
||
| class BaseAdapter(object): | ||
| class BaseAdapter(): |
There was a problem hiding this comment.
Suggested change
| class BaseAdapter(): | |
| class BaseAdapter: |
| @@ -75,7 +75,7 @@ def items_to_dict(items): | |||
| return normalize_dict(dict(res)) | |||
|
|
|||
|
|
|||
| class Counter(object): | |||
| class Counter(): | |||
There was a problem hiding this comment.
Suggested change
| class Counter(): | |
| class Counter: |
| @@ -228,7 +226,7 @@ def id_to_name(config, short_name): | |||
| 'No provider with id={0} found in the config!'.format(short_name)) | |||
|
|
|||
|
|
|||
| class ReprMixin(object): | |||
| class ReprMixin(): | |||
There was a problem hiding this comment.
Suggested change
| class ReprMixin(): | |
| class ReprMixin: |
| @@ -11,7 +11,7 @@ | |||
| import abc | |||
|
|
|||
|
|
|||
| class BaseSession(object): | |||
| class BaseSession(): | |||
There was a problem hiding this comment.
Suggested change
| class BaseSession(): | |
| class BaseSession: |
| @@ -53,7 +53,7 @@ def get(self, key): | |||
| """ | |||
|
|
|||
|
|
|||
| class BaseConfig(object): | |||
| class BaseConfig(): | |||
There was a problem hiding this comment.
Suggested change
| class BaseConfig(): | |
| class BaseConfig: |
|
|
||
| return wrap | ||
|
|
||
|
|
||
| class BaseProvider(object): | ||
| class BaseProvider(): |
There was a problem hiding this comment.
Suggested change
| class BaseProvider(): | |
| class BaseProvider: |
| @@ -70,7 +70,7 @@ | |||
| """ | |||
|
|
|||
|
|
|||
| class SessionOpenIDStore(object): | |||
| class SessionOpenIDStore(): | |||
There was a problem hiding this comment.
Suggested change
| class SessionOpenIDStore(): | |
| class SessionOpenIDStore: |
| @@ -102,7 +102,7 @@ def _create_base_string(method, base, params): | |||
| return _join_by_ampersand(method, base, normalized_qs) | |||
|
|
|||
|
|
|||
| class BaseSignatureGenerator(object): | |||
| class BaseSignatureGenerator(): | |||
There was a problem hiding this comment.
Suggested change
| class BaseSignatureGenerator(): | |
| class BaseSignatureGenerator: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've gone through the output of
pylintandpyflakesand tried to pick off low-hanging fruit.It should be a noop commit, but it would be good to have a 2nd pair of eyes review this one, as it's lots of small changes so the chance of mistakes are higher.
This should fix #34, #222, #232, add some future-proofing and simplify some code.