remove max value on LR optional limit #79
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The thinking is that in v2 the limit will no longer be optional. It could still be runtime configuration though, it just makes the API harder to discover. @josephschorr thoughts? |
|
Yep, that's was the plan and exactly why we added the limit. Whether it remains an API one vs configurable is mostly around discovery, as @jakedt said |
|
Can we repurpose this PR into adding comment that documents this intention? |
|
Removed in 41697b7 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The limit is already optional so capping it at 1000 is counterintuitive. We can add flags to set/validate a max value in spicedb at runtime that users can configure.