-
Notifications
You must be signed in to change notification settings - Fork 246
/
namespace.go
300 lines (238 loc) · 10.8 KB
/
namespace.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
package test
import (
"context"
"errors"
"testing"
"github.com/google/go-cmp/cmp"
"github.com/stretchr/testify/require"
"google.golang.org/protobuf/testing/protocmp"
"github.com/authzed/spicedb/internal/testfixtures"
"github.com/authzed/spicedb/pkg/datastore"
ns "github.com/authzed/spicedb/pkg/namespace"
"github.com/authzed/spicedb/pkg/schemadsl/compiler"
"github.com/authzed/spicedb/pkg/schemadsl/generator"
"github.com/authzed/spicedb/pkg/schemadsl/input"
"github.com/authzed/spicedb/pkg/testutil"
"github.com/authzed/spicedb/pkg/tuple"
)
var (
testNamespace = ns.Namespace("foo/bar",
ns.MustRelation("editor", nil, ns.AllowedRelation(testUserNS.Name, "...")),
)
updatedNamespace = ns.Namespace(testNamespace.Name,
ns.MustRelation("reader", nil, ns.AllowedRelation(testUserNS.Name, "...")),
ns.MustRelation("editor", nil, ns.AllowedRelation(testUserNS.Name, "...")),
)
)
// NamespaceNotFoundTest tests to ensure that an unknown namespace returns the expected
// error.
func NamespaceNotFoundTest(t *testing.T, tester DatastoreTester) {
require := require.New(t)
ds, err := tester.New(0, veryLargeGCInterval, veryLargeGCWindow, 1)
require.NoError(err)
ctx := context.Background()
startRevision, err := ds.HeadRevision(ctx)
require.NoError(err)
require.True(startRevision.GreaterThan(datastore.NoRevision))
_, _, err = ds.SnapshotReader(startRevision).ReadNamespaceByName(ctx, "unknown")
require.True(errors.As(err, &datastore.ErrNamespaceNotFound{}))
}
// NamespaceWriteTest tests whether or not the requirements for writing
// namespaces hold for a particular datastore.
func NamespaceWriteTest(t *testing.T, tester DatastoreTester) {
require := require.New(t)
ds, err := tester.New(0, veryLargeGCInterval, veryLargeGCWindow, 1)
require.NoError(err)
ctx := context.Background()
startRevision, err := ds.HeadRevision(ctx)
require.NoError(err)
require.True(startRevision.GreaterThan(datastore.NoRevision))
nsDefs, err := ds.SnapshotReader(startRevision).ListAllNamespaces(ctx)
require.NoError(err)
require.Equal(0, len(nsDefs))
writtenRev, err := ds.ReadWriteTx(ctx, func(rwt datastore.ReadWriteTransaction) error {
return rwt.WriteNamespaces(ctx, testUserNS)
})
require.NoError(err)
require.True(writtenRev.GreaterThan(startRevision))
nsDefs, err = ds.SnapshotReader(writtenRev).ListAllNamespaces(ctx)
require.NoError(err)
require.Equal(1, len(nsDefs))
require.Equal(testUserNS.Name, nsDefs[0].Definition.Name)
secondWritten, err := ds.ReadWriteTx(ctx, func(rwt datastore.ReadWriteTransaction) error {
return rwt.WriteNamespaces(ctx, testNamespace)
})
require.NoError(err)
require.True(secondWritten.GreaterThan(writtenRev))
nsDefs, err = ds.SnapshotReader(secondWritten).ListAllNamespaces(ctx)
require.NoError(err)
require.Equal(2, len(nsDefs))
_, _, err = ds.SnapshotReader(writtenRev).ReadNamespaceByName(ctx, testNamespace.Name)
require.Error(err)
nsDefs, err = ds.SnapshotReader(writtenRev).ListAllNamespaces(ctx)
require.NoError(err)
require.Equal(1, len(nsDefs))
found, createdRev, err := ds.SnapshotReader(secondWritten).ReadNamespaceByName(ctx, testNamespace.Name)
require.NoError(err)
require.False(createdRev.GreaterThan(secondWritten))
require.True(createdRev.GreaterThan(startRevision))
foundDiff := cmp.Diff(testNamespace, found, protocmp.Transform())
require.Empty(foundDiff)
updatedRevision, err := ds.ReadWriteTx(ctx, func(rwt datastore.ReadWriteTransaction) error {
return rwt.WriteNamespaces(ctx, updatedNamespace)
})
require.NoError(err)
checkUpdated, createdRev, err := ds.SnapshotReader(updatedRevision).ReadNamespaceByName(ctx, testNamespace.Name)
require.NoError(err)
require.False(createdRev.GreaterThan(updatedRevision))
require.True(createdRev.GreaterThan(startRevision))
foundUpdated := cmp.Diff(updatedNamespace, checkUpdated, protocmp.Transform())
require.Empty(foundUpdated)
checkOld, createdRev, err := ds.SnapshotReader(writtenRev).ReadNamespaceByName(ctx, testUserNamespace)
require.NoError(err)
require.False(createdRev.GreaterThan(writtenRev))
require.True(createdRev.GreaterThan(startRevision))
require.Empty(cmp.Diff(testUserNS, checkOld, protocmp.Transform()))
checkOldList, err := ds.SnapshotReader(writtenRev).ListAllNamespaces(ctx)
require.NoError(err)
require.Equal(1, len(checkOldList))
require.Equal(testUserNS.Name, checkOldList[0].Definition.Name)
require.Empty(cmp.Diff(testUserNS, checkOldList[0].Definition, protocmp.Transform()))
checkLookup, err := ds.SnapshotReader(secondWritten).LookupNamespacesWithNames(ctx, []string{testNamespace.Name})
require.NoError(err)
require.Equal(1, len(checkLookup))
require.Equal(testNamespace.Name, checkLookup[0].Definition.Name)
require.Empty(cmp.Diff(testNamespace, checkLookup[0].Definition, protocmp.Transform()))
checkLookupMultiple, err := ds.SnapshotReader(secondWritten).LookupNamespacesWithNames(ctx, []string{testNamespace.Name, testUserNS.Name})
require.NoError(err)
require.Equal(2, len(checkLookupMultiple))
emptyLookup, err := ds.SnapshotReader(secondWritten).LookupNamespacesWithNames(ctx, []string{"anothername"})
require.NoError(err)
require.Equal(0, len(emptyLookup))
}
// NamespaceDeleteTest tests whether or not the requirements for deleting
// namespaces hold for a particular datastore.
func NamespaceDeleteTest(t *testing.T, tester DatastoreTester) {
require := require.New(t)
rawDS, err := tester.New(0, veryLargeGCInterval, veryLargeGCWindow, 1)
require.NoError(err)
ds, revision := testfixtures.StandardDatastoreWithData(rawDS, require)
ctx := context.Background()
tRequire := testfixtures.TupleChecker{Require: require, DS: ds}
docTpl := tuple.Parse(testfixtures.StandardTuples[0])
require.NotNil(docTpl)
tRequire.TupleExists(ctx, docTpl, revision)
folderTpl := tuple.Parse(testfixtures.StandardTuples[2])
require.NotNil(folderTpl)
tRequire.TupleExists(ctx, folderTpl, revision)
deletedRev, err := ds.ReadWriteTx(ctx, func(rwt datastore.ReadWriteTransaction) error {
return rwt.DeleteNamespaces(ctx, testfixtures.DocumentNS.Name)
})
require.NoError(err)
require.True(deletedRev.GreaterThan(revision))
_, _, err = ds.SnapshotReader(deletedRev).ReadNamespaceByName(ctx, testfixtures.DocumentNS.Name)
require.True(errors.As(err, &datastore.ErrNamespaceNotFound{}))
found, nsCreatedRev, err := ds.SnapshotReader(deletedRev).ReadNamespaceByName(ctx, testfixtures.FolderNS.Name)
require.NotNil(found)
require.True(nsCreatedRev.LessThan(deletedRev))
require.NoError(err)
allNamespaces, err := ds.SnapshotReader(deletedRev).ListAllNamespaces(ctx)
require.NoError(err)
for _, ns := range allNamespaces {
require.NotEqual(testfixtures.DocumentNS.Name, ns.Definition.Name, "deleted namespace '%s' should not be in namespace list", ns.Definition.Name)
}
deletedRevision, err := ds.HeadRevision(ctx)
require.NoError(err)
iter, err := ds.SnapshotReader(deletedRevision).QueryRelationships(ctx, datastore.RelationshipsFilter{
ResourceType: testfixtures.DocumentNS.Name,
})
require.NoError(err)
tRequire.VerifyIteratorResults(iter)
tRequire.TupleExists(ctx, folderTpl, deletedRevision)
}
func NamespaceMultiDeleteTest(t *testing.T, tester DatastoreTester) {
rawDS, err := tester.New(0, veryLargeGCInterval, veryLargeGCWindow, 1)
require.NoError(t, err)
ds, revision := testfixtures.StandardDatastoreWithData(rawDS, require.New(t))
ctx := context.Background()
namespaces, err := ds.SnapshotReader(revision).ListAllNamespaces(ctx)
require.NoError(t, err)
nsNames := make([]string, 0, len(namespaces))
for _, ns := range namespaces {
nsNames = append(nsNames, ns.Definition.Name)
}
deletedRev, err := ds.ReadWriteTx(ctx, func(rwt datastore.ReadWriteTransaction) error {
return rwt.DeleteNamespaces(ctx, nsNames...)
})
require.NoError(t, err)
namespacesAfterDel, err := ds.SnapshotReader(deletedRev).ListAllNamespaces(ctx)
require.NoError(t, err)
require.Len(t, namespacesAfterDel, 0)
}
// EmptyNamespaceDeleteTest tests deleting an empty namespace in the datastore.
func EmptyNamespaceDeleteTest(t *testing.T, tester DatastoreTester) {
require := require.New(t)
rawDS, err := tester.New(0, veryLargeGCInterval, veryLargeGCWindow, 1)
require.NoError(err)
ds, revision := testfixtures.StandardDatastoreWithData(rawDS, require)
ctx := context.Background()
deletedRev, err := ds.ReadWriteTx(ctx, func(rwt datastore.ReadWriteTransaction) error {
return rwt.DeleteNamespaces(ctx, testfixtures.UserNS.Name)
})
require.NoError(err)
require.True(deletedRev.GreaterThan(revision))
_, _, err = ds.SnapshotReader(deletedRev).ReadNamespaceByName(ctx, testfixtures.UserNS.Name)
require.True(errors.As(err, &datastore.ErrNamespaceNotFound{}))
}
// StableNamespaceReadWriteTest tests writing a namespace to the datastore and reading it back,
// ensuring that it does not change in any way and that the deserialized data matches that stored.
func StableNamespaceReadWriteTest(t *testing.T, tester DatastoreTester) {
require := require.New(t)
schemaString := `caveat foo(someParam int) {
someParam == 42
}
definition document {
relation viewer: user | user:*
relation editor: user | group#member with foo
relation parent: organization
permission edit = editor
permission view = viewer + edit + parent->view
permission other = viewer - edit
permission intersect = viewer & edit
permission with_nil = (viewer - edit) & parent->view & nil
}`
// Compile namespace to write to the datastore.
empty := ""
compiled, err := compiler.Compile(compiler.InputSchema{
Source: input.Source("schema"),
SchemaString: schemaString,
}, &empty)
require.NoError(err)
require.Equal(2, len(compiled.OrderedDefinitions))
// Write the namespace definition to the datastore.
ds, err := tester.New(0, veryLargeGCInterval, veryLargeGCWindow, 1)
require.NoError(err)
ctx := context.Background()
updatedRevision, err := ds.ReadWriteTx(ctx, func(rwt datastore.ReadWriteTransaction) error {
err := rwt.WriteCaveats(ctx, compiled.CaveatDefinitions)
if err != nil {
return err
}
return rwt.WriteNamespaces(ctx, compiled.ObjectDefinitions...)
})
require.NoError(err)
// Read the namespace definition back from the datastore and compare.
nsConfig := compiled.ObjectDefinitions[0]
readNsDef, _, err := ds.SnapshotReader(updatedRevision).ReadNamespaceByName(ctx, nsConfig.Name)
require.NoError(err)
testutil.RequireProtoEqual(t, nsConfig, readNsDef, "found changed namespace definition")
// Read the caveat back from the datastore and compare.
caveatDef := compiled.CaveatDefinitions[0]
readCaveatDef, _, err := ds.SnapshotReader(updatedRevision).ReadCaveatByName(ctx, caveatDef.Name)
require.NoError(err)
testutil.RequireProtoEqual(t, caveatDef, readCaveatDef, "found changed caveat definition")
// Ensure the read namespace's string form matches the input as an extra check.
generated, _, err := generator.GenerateSchema([]compiler.SchemaDefinition{readCaveatDef, readNsDef})
require.NoError(err)
require.Equal(schemaString, generated)
}