/
expand.go
394 lines (345 loc) · 12.7 KB
/
expand.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
package graph
import (
"context"
"errors"
v0 "github.com/authzed/authzed-go/proto/authzed/api/v0"
v1_proto "github.com/authzed/authzed-go/proto/authzed/api/v1"
"github.com/rs/zerolog/log"
"github.com/shopspring/decimal"
"github.com/authzed/spicedb/internal/datastore"
"github.com/authzed/spicedb/internal/dispatch"
"github.com/authzed/spicedb/internal/namespace"
v1 "github.com/authzed/spicedb/internal/proto/dispatch/v1"
)
type startInclusion int
const (
includeStart startInclusion = iota
excludeStart
)
// NewConcurrentExpander creates an instance of ConcurrentExpander
func NewConcurrentExpander(d dispatch.Expand, ds datastore.GraphDatastore, nsm namespace.Manager) *ConcurrentExpander {
return &ConcurrentExpander{d: d, ds: ds, nsm: nsm}
}
// ConcurrentExpander exposes a method to perform Expand requests, and delegates subproblems to the
// provided dispatch.Expand instance.
type ConcurrentExpander struct {
d dispatch.Expand
ds datastore.GraphDatastore
nsm namespace.Manager
}
// ValidatedExpandRequest represents a request after it has been validated and parsed for internal
// consumption.
type ValidatedExpandRequest struct {
*v1.DispatchExpandRequest
Revision decimal.Decimal
}
// Expand performs an expand request with the provided request and context.
func (ce *ConcurrentExpander) Expand(ctx context.Context, req ValidatedExpandRequest, relation *v0.Relation) (*v1.DispatchExpandResponse, error) {
log.Ctx(ctx).Trace().Object("expand", req).Send()
var directFunc ReduceableExpandFunc
if relation.UsersetRewrite == nil {
directFunc = ce.expandDirect(ctx, req, includeStart)
} else {
directFunc = ce.expandUsersetRewrite(ctx, req, relation.UsersetRewrite)
}
resolved := expandOne(ctx, directFunc)
resolved.Resp.Metadata = addCallToResponseMetadata(resolved.Resp.Metadata)
return resolved.Resp, resolved.Err
}
func (ce *ConcurrentExpander) expandDirect(
ctx context.Context,
req ValidatedExpandRequest,
startBehavior startInclusion,
) ReduceableExpandFunc {
log.Ctx(ctx).Trace().Object("direct", req).Send()
return func(ctx context.Context, resultChan chan<- ExpandResult) {
it, err := ce.ds.QueryTuples(ctx, &v1_proto.RelationshipFilter{
ResourceType: req.ObjectAndRelation.Namespace,
OptionalResourceId: req.ObjectAndRelation.ObjectId,
OptionalRelation: req.ObjectAndRelation.Relation,
}, req.Revision)
if err != nil {
resultChan <- expandResultError(NewExpansionFailureErr(err), emptyMetadata)
return
}
defer it.Close()
var foundNonTerminalUsersets []*v0.User
var foundTerminalUsersets []*v0.User
for tpl := it.Next(); tpl != nil; tpl = it.Next() {
if tpl.User.GetUserset().Relation == Ellipsis {
foundTerminalUsersets = append(foundTerminalUsersets, tpl.User)
} else {
foundNonTerminalUsersets = append(foundNonTerminalUsersets, tpl.User)
}
}
if it.Err() != nil {
resultChan <- expandResultError(NewExpansionFailureErr(it.Err()), emptyMetadata)
return
}
// In some cases (such as _this{} expansion) including the start point is misleading.
var start *v0.ObjectAndRelation
if startBehavior == includeStart {
start = req.ObjectAndRelation
}
// If only shallow expansion was required, or there are no non-terminal subjects found,
// nothing more to do.
if req.ExpansionMode == v1.DispatchExpandRequest_SHALLOW || len(foundNonTerminalUsersets) == 0 {
resultChan <- expandResult(
&v0.RelationTupleTreeNode{
NodeType: &v0.RelationTupleTreeNode_LeafNode{
LeafNode: &v0.DirectUserset{
Users: append(foundTerminalUsersets, foundNonTerminalUsersets...),
},
},
Expanded: start,
},
emptyMetadata,
)
return
}
// Otherwise, recursively issue expansion and collect the results from that, plus the
// found terminals together.
var requestsToDispatch []ReduceableExpandFunc
for _, nonTerminalUser := range foundNonTerminalUsersets {
requestsToDispatch = append(requestsToDispatch, ce.dispatch(ValidatedExpandRequest{
&v1.DispatchExpandRequest{
ObjectAndRelation: nonTerminalUser.GetUserset(),
Metadata: decrementDepth(req.Metadata),
ExpansionMode: req.ExpansionMode,
},
req.Revision,
}))
}
result := expandAny(ctx, req.ObjectAndRelation, requestsToDispatch)
if result.Err != nil {
resultChan <- result
return
}
unionNode := result.Resp.TreeNode.GetIntermediateNode()
unionNode.ChildNodes = append(unionNode.ChildNodes, &v0.RelationTupleTreeNode{
NodeType: &v0.RelationTupleTreeNode_LeafNode{
LeafNode: &v0.DirectUserset{
Users: append(foundTerminalUsersets, foundNonTerminalUsersets...),
},
},
Expanded: start,
})
resultChan <- result
}
}
func (ce *ConcurrentExpander) expandUsersetRewrite(ctx context.Context, req ValidatedExpandRequest, usr *v0.UsersetRewrite) ReduceableExpandFunc {
switch rw := usr.RewriteOperation.(type) {
case *v0.UsersetRewrite_Union:
log.Ctx(ctx).Trace().Msg("union")
return ce.expandSetOperation(ctx, req, rw.Union, expandAny)
case *v0.UsersetRewrite_Intersection:
log.Ctx(ctx).Trace().Msg("intersection")
return ce.expandSetOperation(ctx, req, rw.Intersection, expandAll)
case *v0.UsersetRewrite_Exclusion:
log.Ctx(ctx).Trace().Msg("exclusion")
return ce.expandSetOperation(ctx, req, rw.Exclusion, expandDifference)
default:
return alwaysFailExpand
}
}
func (ce *ConcurrentExpander) expandSetOperation(ctx context.Context, req ValidatedExpandRequest, so *v0.SetOperation, reducer ExpandReducer) ReduceableExpandFunc {
var requests []ReduceableExpandFunc
for _, childOneof := range so.Child {
switch child := childOneof.ChildType.(type) {
case *v0.SetOperation_Child_XThis:
requests = append(requests, ce.expandDirect(ctx, req, excludeStart))
case *v0.SetOperation_Child_ComputedUserset:
requests = append(requests, ce.expandComputedUserset(ctx, req, child.ComputedUserset, nil))
case *v0.SetOperation_Child_UsersetRewrite:
requests = append(requests, ce.expandUsersetRewrite(ctx, req, child.UsersetRewrite))
case *v0.SetOperation_Child_TupleToUserset:
requests = append(requests, ce.expandTupleToUserset(ctx, req, child.TupleToUserset))
}
}
return func(ctx context.Context, resultChan chan<- ExpandResult) {
resultChan <- reducer(ctx, req.ObjectAndRelation, requests)
}
}
func (ce *ConcurrentExpander) dispatch(req ValidatedExpandRequest) ReduceableExpandFunc {
return func(ctx context.Context, resultChan chan<- ExpandResult) {
log.Ctx(ctx).Trace().Object("dispatch expand", req).Send()
result, err := ce.d.DispatchExpand(ctx, req.DispatchExpandRequest)
resultChan <- ExpandResult{result, err}
}
}
func (ce *ConcurrentExpander) expandComputedUserset(ctx context.Context, req ValidatedExpandRequest, cu *v0.ComputedUserset, tpl *v0.RelationTuple) ReduceableExpandFunc {
log.Ctx(ctx).Trace().Str("relation", cu.Relation).Msg("computed userset")
var start *v0.ObjectAndRelation
if cu.Object == v0.ComputedUserset_TUPLE_USERSET_OBJECT {
if tpl == nil {
// TODO replace this with something else, AlwaysFail?
panic("computed userset for tupleset without tuple")
}
start = tpl.User.GetUserset()
} else if cu.Object == v0.ComputedUserset_TUPLE_OBJECT {
if tpl != nil {
start = tpl.ObjectAndRelation
} else {
start = req.ObjectAndRelation
}
}
// Check if the target relation exists. If not, return nothing.
err := ce.nsm.CheckNamespaceAndRelation(ctx, start.Namespace, cu.Relation, true, req.Revision)
if err != nil {
if errors.As(err, &namespace.ErrRelationNotFound{}) {
return emptyExpansion(req.ObjectAndRelation)
}
return expandError(err)
}
return ce.dispatch(ValidatedExpandRequest{
&v1.DispatchExpandRequest{
ObjectAndRelation: &v0.ObjectAndRelation{
Namespace: start.Namespace,
ObjectId: start.ObjectId,
Relation: cu.Relation,
},
Metadata: decrementDepth(req.Metadata),
ExpansionMode: req.ExpansionMode,
},
req.Revision,
})
}
func (ce *ConcurrentExpander) expandTupleToUserset(ctx context.Context, req ValidatedExpandRequest, ttu *v0.TupleToUserset) ReduceableExpandFunc {
return func(ctx context.Context, resultChan chan<- ExpandResult) {
it, err := ce.ds.QueryTuples(ctx, &v1_proto.RelationshipFilter{
ResourceType: req.ObjectAndRelation.Namespace,
OptionalResourceId: req.ObjectAndRelation.ObjectId,
OptionalRelation: ttu.Tupleset.Relation,
}, req.Revision)
if err != nil {
resultChan <- expandResultError(NewExpansionFailureErr(err), emptyMetadata)
return
}
defer it.Close()
var requestsToDispatch []ReduceableExpandFunc
for tpl := it.Next(); tpl != nil; tpl = it.Next() {
requestsToDispatch = append(requestsToDispatch, ce.expandComputedUserset(ctx, req, ttu.ComputedUserset, tpl))
}
if it.Err() != nil {
resultChan <- expandResultError(NewExpansionFailureErr(it.Err()), emptyMetadata)
return
}
resultChan <- expandAny(ctx, req.ObjectAndRelation, requestsToDispatch)
}
}
func setResult(
op v0.SetOperationUserset_Operation,
start *v0.ObjectAndRelation,
children []*v0.RelationTupleTreeNode,
metadata *v1.ResponseMeta,
) ExpandResult {
return expandResult(
&v0.RelationTupleTreeNode{
NodeType: &v0.RelationTupleTreeNode_IntermediateNode{
IntermediateNode: &v0.SetOperationUserset{
Operation: op,
ChildNodes: children,
},
},
Expanded: start,
},
metadata,
)
}
func expandSetOperation(
ctx context.Context,
start *v0.ObjectAndRelation,
requests []ReduceableExpandFunc,
op v0.SetOperationUserset_Operation,
) ExpandResult {
children := make([]*v0.RelationTupleTreeNode, 0, len(requests))
if len(requests) == 0 {
return setResult(op, start, children, emptyMetadata)
}
childCtx, cancelFn := context.WithCancel(ctx)
defer cancelFn()
resultChans := make([]chan ExpandResult, 0, len(requests))
for _, req := range requests {
resultChan := make(chan ExpandResult)
resultChans = append(resultChans, resultChan)
go req(childCtx, resultChan)
}
responseMetadata := emptyMetadata
for _, resultChan := range resultChans {
select {
case result := <-resultChan:
responseMetadata = combineResponseMetadata(responseMetadata, result.Resp.Metadata)
if result.Err != nil {
return expandResultError(result.Err, responseMetadata)
}
children = append(children, result.Resp.TreeNode)
case <-ctx.Done():
return expandResultError(NewRequestCanceledErr(), responseMetadata)
}
}
return setResult(op, start, children, responseMetadata)
}
// emptyExpansion returns an empty expansion.
func emptyExpansion(start *v0.ObjectAndRelation) ReduceableExpandFunc {
return func(ctx context.Context, resultChan chan<- ExpandResult) {
resultChan <- expandResult(&v0.RelationTupleTreeNode{
NodeType: &v0.RelationTupleTreeNode_LeafNode{
LeafNode: &v0.DirectUserset{},
},
Expanded: start,
}, emptyMetadata)
}
}
// expandError returns the error.
func expandError(err error) ReduceableExpandFunc {
return func(ctx context.Context, resultChan chan<- ExpandResult) {
resultChan <- expandResultError(err, emptyMetadata)
}
}
// expandAll returns a tree with all of the children and an intersection node type.
func expandAll(ctx context.Context, start *v0.ObjectAndRelation, requests []ReduceableExpandFunc) ExpandResult {
return expandSetOperation(ctx, start, requests, v0.SetOperationUserset_INTERSECTION)
}
// expandAny returns a tree with all of the children and a union node type.
func expandAny(ctx context.Context, start *v0.ObjectAndRelation, requests []ReduceableExpandFunc) ExpandResult {
return expandSetOperation(ctx, start, requests, v0.SetOperationUserset_UNION)
}
// expandDifference returns a tree with all of the children and an exclusion node type.
func expandDifference(ctx context.Context, start *v0.ObjectAndRelation, requests []ReduceableExpandFunc) ExpandResult {
return expandSetOperation(ctx, start, requests, v0.SetOperationUserset_EXCLUSION)
}
// expandOne waits for exactly one response
func expandOne(ctx context.Context, request ReduceableExpandFunc) ExpandResult {
resultChan := make(chan ExpandResult, 1)
go request(ctx, resultChan)
select {
case result := <-resultChan:
if result.Err != nil {
return result
}
return result
case <-ctx.Done():
return expandResultError(NewRequestCanceledErr(), emptyMetadata)
}
}
var errAlwaysFailExpand = errors.New("always fail")
func alwaysFailExpand(ctx context.Context, resultChan chan<- ExpandResult) {
resultChan <- expandResultError(errAlwaysFailExpand, emptyMetadata)
}
func expandResult(treeNode *v0.RelationTupleTreeNode, subProblemMetadata *v1.ResponseMeta) ExpandResult {
return ExpandResult{
&v1.DispatchExpandResponse{
Metadata: ensureMetadata(subProblemMetadata),
TreeNode: treeNode,
},
nil,
}
}
func expandResultError(err error, subProblemMetadata *v1.ResponseMeta) ExpandResult {
return ExpandResult{
&v1.DispatchExpandResponse{
Metadata: ensureMetadata(subProblemMetadata),
},
err,
}
}