Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Memdb: Unify revisions between Namepaces and Relationships #270

Closed
jakedt opened this issue Nov 9, 2021 · 1 comment
Closed

Memdb: Unify revisions between Namepaces and Relationships #270

jakedt opened this issue Nov 9, 2021 · 1 comment
Labels
area/datastore Affects the storage system hint/good first issue Someone new could handle this priority/2 medium This needs to be done

Comments

@jakedt
Copy link
Member

jakedt commented Nov 9, 2021

Memdb has a separate changelog table for namespaces and relationships. Our other datastores use a unified revision space between those operations, which means that you can pass a revision from a namespace operation to a future relationship operation (e.g. watch).

Memdb should have its revision generation (and likely changelog implementation) unified to bring it in line with other datastores.
@jakedt jakedt added hint/good first issue Someone new could handle this priority/2 medium This needs to be done area/datastore Affects the storage system labels Nov 9, 2021
@jakedt jakedt mentioned this issue Nov 9, 2021
Closed
@jakedt jakedt mentioned this issue Dec 6, 2021
Merged
@ecordell
Copy link
Contributor

ecordell commented Dec 9, 2021

Fixed by #319

@ecordell ecordell closed this as completed Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/datastore Affects the storage system hint/good first issue Someone new could handle this priority/2 medium This needs to be done
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ecordell @jakedt