Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deny-overrides rule combining algorithm - Missing obligations in case of multiple Permit Rules and no Deny Rule #92

Closed
cdanger opened this issue Nov 16, 2023 Discussed in #90 · 1 comment
Assignees
Labels
Milestone

Comments

@cdanger
Copy link
Member

cdanger commented Nov 16, 2023

Discussed in #90

Originally posted by zeno521 November 9, 2023
Hi AuthzForce team,

We are working on a POC with Authzforce PDP engine. We have multiple permit rules (each with obligations) in a policy with deny overrides rule combining algorithm. We expected the obligations from all rules to be returned in the results when all the rules and policy return Permit. However, we can only see the obligations returned from the first permit rule.

Could you indicate if this is an expected behaviour please? If it is, how to return the obligations from all the rules?

Your earliest response is highly appreciated!

Tested with authzforce-ce-core-pdp-engine-20.3.2.jar.

@cdanger
Copy link
Member Author

cdanger commented Nov 16, 2023

Bug confirmed when there are multiple Permit Rules and no Deny Rule, then only the obligations of the first Permit Rule are returned.

(Works as expected if there is at least one Deny Rule.)

@cdanger cdanger self-assigned this Nov 16, 2023
@cdanger cdanger added the bug label Nov 16, 2023
@cdanger cdanger added this to the 21.0.1 milestone Nov 16, 2023
cdanger added a commit that referenced this issue Nov 23, 2023
- Added tests on Rules' Obligations and combining Obligations from multiple Rules: pdp-testutils/src/test/resources/conformance/others/Rule_Obligations.*
- Refactoring/merging code of DPOverridesCombiningAlg and DPUnlessPDCombiningAlg classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant