Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate new cmd for credit usage and project info api #468

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Generate new cmd for credit usage and project info api #468

merged 1 commit into from
Nov 8, 2023

Conversation

henchiyb
Copy link
Contributor

@henchiyb henchiyb commented Nov 7, 2023 •
edited
Loading

Execute npm run generate

@henchiyb henchiyb self-assigned this Nov 7, 2023
@henchiyb henchiyb requested a review from a team November 7, 2023 06:50
@4ydx
Copy link
Contributor

4ydx commented Nov 7, 2023

Will you be adding any tests?

@henchiyb
Copy link
Contributor Author

henchiyb commented Nov 7, 2023

@4ydx I don't see we have any test for web api, only have integration tests for web test run .
We have test for api endpoint so for the CLI just generate the command is enough I guess? 🤔

4ydx
4ydx approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@4ydx 4ydx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok np lets just stick with the current approach.

@henchiyb henchiyb merged commit a8dea3e into main Nov 8, 2023
29 checks passed
@henchiyb henchiyb deleted the generate-new-cmd branch November 8, 2023 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4ydx 4ydx 4ydx approved these changes

Assignees

@henchiyb henchiyb

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@henchiyb @4ydx