Proper handling of [return] and [tab] in ac-fallback-command

[vspinu]

ac-completing-map defines actions on [return] and [tab]. Most of the modes
define RET and TAB keys as "\r" and "\t". Thus, when ac-fallback-command searches
for a command it fails to find it when it is bound to "\r" or "\t".

This patch corrects this issue.

[yyr]

+1

[monsanto]

This patch contains other commits other than fixing this issue. I'll have to cherry pick f6750b2.

[vspinu]

Ah sorry, it's a mess up. Don't really understand what happen. So could
you cherry pick, or I can clean it up.

Christopher Monsanto notifications@github.com
on Wed, 29 Aug 2012 10:47:52 -0700 wrote:

This patch contains other commits other than fixing this issue. I'll have to cherry pick f6750b2.

Reply to this email directly or view it on GitHub:
#109 (comment)

[vspinu]

Ah yes, I remember. I have merge the main branch into it. Let me try to clean it up.

[vspinu]

Ok I have cleaned it. It contains only one commit. Please merge.

[m2ym]

Your fix seems to be specific. How about this instead?

diff --git a/auto-complete.el b/auto-complete.el
index b31d430..7f7267d 100644
--- a/auto-complete.el
+++ b/auto-complete.el
@@ -1587,10 +1587,16 @@ that have been made before in this function."
            (string-match "self-insert-command" (symbol-name command))
            (string-match "electric" (symbol-name command)))))

+(defun ac-fallback-key-sequence ()
+  (setq unread-command-events
+        (append (this-single-command-raw-keys)
+                unread-command-events))
+  (read-key-sequence-vector ""))
+
 (defun ac-fallback-command (&optional except-command)
   (let* ((auto-complete-mode nil)
-         (keys (this-command-keys-vector))
-         (command (if keys (key-binding keys))))
+         (keys (ac-fallback-key-sequence))
+         (command (and keys (key-binding keys))))
     (when (and (commandp command)
                (not (eq command except-command)))
       (setq this-command command)

[vspinu]

Yes, that seems to work. Thanks.

[m2ym]

Fixed 2dbabec