Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mesh: Add virtual address before using it #961

Merged
merged 1 commit into from
Jun 28, 2023
Merged

mesh: Add virtual address before using it #961

merged 1 commit into from
Jun 28, 2023

Conversation

PavelVPV
Copy link
Contributor

@PavelVPV PavelVPV commented Jun 21, 2023 •
edited
Loading

Virtual address behavior has been changed in this PR: zephyrproject-rtos/zephyr#57878

Now it requires label uuid to be added before any message can be sent and desired uuid should be passed to message context structure before sending a message to a virtual address.

This change should fix MESH/NODE/NET/BV-02-C and MESH/NODE/TNPT/BV-05-C failing tests.

For MESH/NODE/NET/BV-02-C the virtual address is added on hdl_wid_21 as PTS asks the stack to provide known virtual address.

For MESH/NODE/TNPT/BV-05-C PTS gives the label uuid in the message, therefore we need to add this address first before sending a message to it.

Corresponding PR to zephyrproject-rtos:
zephyrproject-rtos/zephyr#59486

PavelVPV added a commit to PavelVPV/zephyr that referenced this pull request Jun 21, 2023
@PavelVPV
bluetooth: tester: Add commands to add and delete virtual addresses
835ad24 
Virtual address behavior has been changed in this PR:
zephyrproject-rtos#57878

Now it is required to register virtual address before using it.

Corresponding PR to auto-pts:
auto-pts/auto-pts#961

Signed-off-by: Pavel Vasilyev <pavel.vasilyev@nordicsemi.no>
@PavelVPV PavelVPV mentioned this pull request Jun 21, 2023
Merged
@PavelVPV PavelVPV force-pushed the virt_addr_fix_new_api branch 2 times, most recently from ab197e0 to d1a824c Compare June 21, 2023 12:04
mkasenberg
mkasenberg approved these changes Jun 27, 2023
View reviewed changes
Copy link
Collaborator

@mkasenberg mkasenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, pls rebase

@PavelVPV
mesh: Add virtual address before using it
c9a159a 
Virtual address behavior has been changed in this PR:
zephyrproject-rtos/zephyr#57878

Now it requires label uuid to be added before any message can be sent
and desired uuid should be passed to message context structure before
sending a message to a virtual address.

This change should fix MESH/NODE/NET/BV-02-C and MESH/NODE/TNPT/BV-05-C
failing tests.

For MESH/NODE/NET/BV-02-C the virtual address is added on hdl_wid_21 as
PTS asks the stack to provide known virtual address.

For MESH/NODE/TNPT/BV-05-C PTS gives the label uuid in the message,
therefore we need to add this address first before sending a message to
it.

Corresponding PR to zephyrproject-rtos:
zephyrproject-rtos/zephyr#59486

Signed-off-by: Pavel Vasilyev <pavel.vasilyev@nordicsemi.no>
sjanc
sjanc approved these changes Jun 28, 2023
View reviewed changes
Copy link
Contributor

@sjanc sjanc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not related to this commit but there seems to be some opcode collision in MESH BTP (maybe just in docs?)

I created issue to not forget about this #965

@mkasenberg mkasenberg merged commit e4a2b34 into auto-pts:master Jun 28, 2023
1 check passed
PavelVPV added a commit to PavelVPV/zephyr that referenced this pull request Jun 28, 2023
@PavelVPV
bluetooth: tester: Add commands to add and delete virtual addresses
7c863e1 
Virtual address behavior has been changed in this PR:
zephyrproject-rtos#57878

Now it is required to register virtual address before using it.

Corresponding PR to auto-pts:
auto-pts/auto-pts#961

Signed-off-by: Pavel Vasilyev <pavel.vasilyev@nordicsemi.no>
PavelVPV added a commit to PavelVPV/zephyr that referenced this pull request Jun 28, 2023
@PavelVPV
bluetooth: tester: Add commands to add and delete virtual addresses
a7d3eab 
Virtual address behavior has been changed in this PR:
zephyrproject-rtos#57878

Now it is required to register virtual address before using it.

Corresponding PR to auto-pts:
auto-pts/auto-pts#961

Signed-off-by: Pavel Vasilyev <pavel.vasilyev@nordicsemi.no>
PavelVPV added a commit to PavelVPV/zephyr that referenced this pull request Jul 3, 2023
@PavelVPV
bluetooth: tester: Add commands to add and delete virtual addresses
0ce867f 
Virtual address behavior has been changed in this PR:
zephyrproject-rtos#57878

Now it is required to register virtual address before using it.

Corresponding PR to auto-pts:
auto-pts/auto-pts#961

Signed-off-by: Pavel Vasilyev <pavel.vasilyev@nordicsemi.no>
PavelVPV added a commit to PavelVPV/zephyr that referenced this pull request Jul 4, 2023
@PavelVPV
bluetooth: tester: Add commands to add and delete virtual addresses
5ca46bc 
Virtual address behavior has been changed in this PR:
zephyrproject-rtos#57878

Now it is required to register virtual address before using it.

Corresponding PR to auto-pts:
auto-pts/auto-pts#961

Signed-off-by: Pavel Vasilyev <pavel.vasilyev@nordicsemi.no>
carlescufi pushed a commit to zephyrproject-rtos/zephyr that referenced this pull request Jul 25, 2023
@PavelVPV @carlescufi
bluetooth: tester: Add commands to add and delete virtual addresses
4d56a31 
Virtual address behavior has been changed in this PR:
#57878

Now it is required to register virtual address before using it.

Corresponding PR to auto-pts:
auto-pts/auto-pts#961

Signed-off-by: Pavel Vasilyev <pavel.vasilyev@nordicsemi.no>
m-alperen-sener pushed a commit to m-alperen-sener/sdk-zephyr that referenced this pull request Jul 25, 2023
@PavelVPV @m-alperen-sener
[nrf fromtree] bluetooth: tester: Add commands to add and delete virt…
a5c6b7d 
…ual addresses

Virtual address behavior has been changed in this PR:
zephyrproject-rtos/zephyr#57878

Now it is required to register virtual address before using it.

Corresponding PR to auto-pts:
auto-pts/auto-pts#961

Signed-off-by: Pavel Vasilyev <pavel.vasilyev@nordicsemi.no>
(cherry picked from commit 4d56a31)
Signed-off-by: Alperen Sener <alperen.sener@nordicsemi.no>
nordicjm pushed a commit to nrfconnect/sdk-zephyr that referenced this pull request Jul 26, 2023
@PavelVPV @nordicjm
[nrf fromtree] bluetooth: tester: Add commands to add and delete virt…
eec94c1 
…ual addresses

Virtual address behavior has been changed in this PR:
zephyrproject-rtos/zephyr#57878

Now it is required to register virtual address before using it.

Corresponding PR to auto-pts:
auto-pts/auto-pts#961

Signed-off-by: Pavel Vasilyev <pavel.vasilyev@nordicsemi.no>
(cherry picked from commit 4d56a31)
Signed-off-by: Alperen Sener <alperen.sener@nordicsemi.no>
coreboot-org-bot pushed a commit to coreboot/zephyr-cros that referenced this pull request Jul 27, 2023
@PavelVPV
bluetooth: tester: Add commands to add and delete virtual addresses
c2c3295 
Virtual address behavior has been changed in this PR:
zephyrproject-rtos/zephyr#57878

Now it is required to register virtual address before using it.

Corresponding PR to auto-pts:
auto-pts/auto-pts#961

(cherry picked from commit 4d56a31)

Original-Signed-off-by: Pavel Vasilyev <pavel.vasilyev@nordicsemi.no>
GitOrigin-RevId: 4d56a31
Change-Id: I8d32b5d0bb9a9fa6983c1a3b5a8bab2529a4c2e8
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/4716825
Tested-by: Fabio Baltieri <fabiobaltieri@google.com>
Tested-by: ChromeOS Prod (Robot) <chromeos-ci-prod@chromeos-bot.iam.gserviceaccount.com>
Reviewed-by: Fabio Baltieri <fabiobaltieri@google.com>
Commit-Queue: Fabio Baltieri <fabiobaltieri@google.com>
DRuffer-tmo pushed a commit to tmobile/DevEdge-IoTDevKit-ZephyrRTOS that referenced this pull request Jul 27, 2023
@PavelVPV @DRuffer-tmo
bluetooth: tester: Add commands to add and delete virtual addresses
eb5082f 
Virtual address behavior has been changed in this PR:
zephyrproject-rtos/zephyr#57878

Now it is required to register virtual address before using it.

Corresponding PR to auto-pts:
auto-pts/auto-pts#961

Signed-off-by: Pavel Vasilyev <pavel.vasilyev@nordicsemi.no>
kunoh pushed a commit to kunoh/zephyr that referenced this pull request Aug 7, 2023
@PavelVPV @kunoh
bluetooth: tester: Add commands to add and delete virtual addresses
c1e955f 
Virtual address behavior has been changed in this PR:
zephyrproject-rtos#57878

Now it is required to register virtual address before using it.

Corresponding PR to auto-pts:
auto-pts/auto-pts#961

Signed-off-by: Pavel Vasilyev <pavel.vasilyev@nordicsemi.no>
DRuffer-tmo pushed a commit to tmobile/DevEdge-IoTDevKit-ZephyrRTOS that referenced this pull request Aug 8, 2023
@PavelVPV @DRuffer-tmo
bluetooth: tester: Add commands to add and delete virtual addresses
a32f9e9 
Virtual address behavior has been changed in this PR:
zephyrproject-rtos/zephyr#57878

Now it is required to register virtual address before using it.

Corresponding PR to auto-pts:
auto-pts/auto-pts#961

Signed-off-by: Pavel Vasilyev <pavel.vasilyev@nordicsemi.no>
umarnisar92 pushed a commit to nisarumar/zephyr that referenced this pull request Aug 15, 2023
@PavelVPV
bluetooth: tester: Add commands to add and delete virtual addresses
86e721b 
Virtual address behavior has been changed in this PR:
zephyrproject-rtos#57878

Now it is required to register virtual address before using it.

Corresponding PR to auto-pts:
auto-pts/auto-pts#961

Signed-off-by: Pavel Vasilyev <pavel.vasilyev@nordicsemi.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjanc sjanc sjanc approved these changes

@mkasenberg mkasenberg mkasenberg approved these changes

@m-alperen-sener m-alperen-sener m-alperen-sener approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PavelVPV @sjanc @mkasenberg @m-alperen-sener