Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should "ARIA allowed attribute" limit itself to only elements included in the accessibility tree? #375

Closed
kasperisager opened this issue Dec 17, 2018 · 2 comments
Closed

Should "ARIA allowed attribute" limit itself to only elements included in the accessibility tree? #375

kasperisager opened this issue Dec 17, 2018 · 2 comments
Assignees
@ShadowBB @annethyme
Labels
Discussion Rule Update Use this label for an existing rule that is being updated Rule Use this label for a new rule that does not exist already

Comments

@kasperisager
Copy link
Contributor

Same reasoning as outlined in #372 (comment). Discussed with @ShadowBB during evaluation of the rule in Alfa.
@ShadowBB ShadowBB self-assigned this Dec 20, 2018
@jeeyyy jeeyyy added Rule Update Use this label for an existing rule that is being updated and removed Rule Update Use this label for an existing rule that is being updated labels Jan 7, 2019
@annethyme annethyme added Rule Update Use this label for an existing rule that is being updated Rule Use this label for a new rule that does not exist already Discussion labels Jan 7, 2019
@annethyme annethyme self-assigned this Mar 12, 2019
@annethyme
Copy link
Collaborator

I am co-assigning this rule myself since I am the owner of this rule inside the WAI-Tools project. It has a deadline of March 31.

ShadowBB added a commit that referenced this issue Mar 12, 2019
@ShadowBB
"aria attribute allowed" and "aria required states and properties" no…
f1cb3f6 
…w only check things in the accessibility tree

In the two rules "aria attribute allowed" and "aria required states and properties" I added "included in the accessibility tree" to the applicablity so to fix issues #375 and #372
@ShadowBB ShadowBB mentioned this issue Mar 12, 2019
Merged
6 tasks
@annethyme
Copy link
Collaborator

Being handled in #436

annethyme pushed a commit that referenced this issue Apr 10, 2019
@ShadowBB
Rule update: "aria attribute allowed" and "aria required states and p…
e6480f5 
…roperties" (#436)

* "aria attribute allowed" and "aria required states and properties" now only check things in the accessibility tree

In the two rules "aria attribute allowed" and "aria required states and properties" I added "included in the accessibility tree" to the applicablity so to fix issues #375 and #372

* Added an inapplicable example

* Added an inapplicable example

* Reworded applicability.

As per suggestions of Anne
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ShadowBB ShadowBB

@annethyme annethyme

Labels
Discussion Rule Update Use this label for an existing rule that is being updated Rule Use this label for a new rule that does not exist already
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kasperisager @ShadowBB @annethyme @jeeyyy