Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid JS imports (without having an export) #752

Closed
mseele opened this issue Oct 20, 2022 · 0 comments Β· Fixed by #753
Closed

Invalid JS imports (without having an export) #752

mseele opened this issue Oct 20, 2022 · 0 comments Β· Fixed by #753

Comments

@mseele
Copy link
Contributor

mseele commented Oct 20, 2022

Hi! πŸ‘‹

Firstly, thanks for your work on this project! πŸ™‚

We run into problems running esbuild via vite against autoNumeric:

✘ [ERROR] No matching export in "node_modules/autonumeric/src/AutoNumericOptions.js" for import "default"

    node_modules/autonumeric/src/AutoNumericDefaultSettings.js:31:7:
      31 β”‚ import AutoNumericOptions from './AutoNumericOptions';
         β•΅        ~~~~~~~~~~~~~~~~~~

✘ [ERROR] No matching export in "node_modules/autonumeric/src/AutoNumericEvents.js" for import "default"

    node_modules/autonumeric/src/main.js:32:7:
      32 β”‚ import AutoNumericEvents from './AutoNumericEvents';
         β•΅        ~~~~~~~~~~~~~~~~~

✘ [ERROR] No matching export in "node_modules/autonumeric/src/AutoNumericOptions.js" for import "default"

    node_modules/autonumeric/src/main.js:33:7:
      33 β”‚ import AutoNumericOptions from './AutoNumericOptions';
         β•΅        ~~~~~~~~~~~~~~~~~~

✘ [ERROR] No matching export in "node_modules/autonumeric/src/AutoNumericDefaultSettings.js" for import "default"

    node_modules/autonumeric/src/main.js:34:7:
      34 β”‚ import AutoNumericDefaultSettings from './AutoNumericDefaultSettings';
         β•΅        ~~~~~~~~~~~~~~~~~~~~~~~~~~

✘ [ERROR] No matching export in "node_modules/autonumeric/src/AutoNumericPredefinedOptions.js" for import "default"

    node_modules/autonumeric/src/main.js:35:7:
      35 β”‚ import AutoNumericPredefinedOptions from './AutoNumericPredefinedOptions';
         β•΅        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~

This might be the same issue what is discussed in #727.

Here is the diff that solved our problems:

diff --git a/node_modules/autonumeric/src/AutoNumericDefaultSettings.js b/node_modules/autonumeric/src/AutoNumericDefaultSettings.js
index 3cd373a..705f61e 100644
--- a/node_modules/autonumeric/src/AutoNumericDefaultSettings.js
+++ b/node_modules/autonumeric/src/AutoNumericDefaultSettings.js
@@ -28,7 +28,7 @@
  */
 
 import AutoNumeric from './AutoNumeric';
-import AutoNumericOptions from './AutoNumericOptions';
+import './AutoNumericOptions';
 
 /* eslint no-unused-vars: 0 */
 
diff --git a/node_modules/autonumeric/src/main.js b/node_modules/autonumeric/src/main.js
index 5334b78..e914ffb 100644
--- a/node_modules/autonumeric/src/main.js
+++ b/node_modules/autonumeric/src/main.js
@@ -29,10 +29,10 @@
  */
 
 import AutoNumeric from './AutoNumeric';
-import AutoNumericEvents from './AutoNumericEvents';
-import AutoNumericOptions from './AutoNumericOptions';
-import AutoNumericDefaultSettings from './AutoNumericDefaultSettings';
-import AutoNumericPredefinedOptions from './AutoNumericPredefinedOptions';
+import './AutoNumericEvents';
+import './AutoNumericOptions';
+import './AutoNumericDefaultSettings';
+import './AutoNumericPredefinedOptions';
 
 /* eslint no-unused-vars: 0 */
 

This issue body was partially generated by patch-package.

mseele pushed a commit to mseele/autoNumeric that referenced this issue Oct 20, 2022
chuchiperriman added a commit to chuchiperriman/autoNumeric that referenced this issue Feb 2, 2023
Hay errores con los import y da error con vite.
closes autoNumeric#752
AlexandreBonneau pushed a commit that referenced this issue Feb 13, 2023
closes #752

Co-authored-by: Michael Seele <michael.seele@guh-software.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant