refactor(apiclient): simplify query in release delete method (#1538)

* refactor(apiclient): simplify query in delete method * refactor(apiclient): simplify query in delete method
autobrr · May 4, 2024 · 2f9b82c · 2f9b82c
1 parent 9832076
commit 2f9b82c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 20 deletions.
diff --git a/web/src/api/APIClient.ts b/web/src/api/APIClient.ts
@@ -15,14 +15,6 @@ interface HttpConfig {
   queryString?: Record<string, Primitive | Primitive[]>;
 }
 
-interface DeleteParams {
-  olderThan?: number;
-  indexers?: string[];
-  releaseStatuses?: string[];
-}
-
-type QueryStringParams = Record<string, string | string[]>;
-
 // See https://stackoverflow.com/a/62969380
 function encodeRFC3986URIComponent(str: string): string {
   return encodeURIComponent(str).replace(
@@ -347,19 +339,12 @@ export const APIClient = {
     indexerOptions: () => appClient.Get<string[]>("api/release/indexers"),
     stats: () => appClient.Get<ReleaseStats>("api/release/stats"),
     delete: (params: DeleteParams) => {
-      const queryString: QueryStringParams = {};
-      if (params.olderThan !== undefined) {
-        queryString.olderThan = params.olderThan.toString();
-      }
-      if (params.indexers && params.indexers.length > 0) {
-        queryString.indexer = params.indexers;
-      }
-      if (params.releaseStatuses && params.releaseStatuses.length > 0) {
-        queryString.releaseStatus = params.releaseStatuses;
-      }
-
       return appClient.Delete("api/release", {
-        queryString
+        queryString: {
+          olderThan: params.olderThan,
+          indexer: params.indexers,
+          releaseStatus: params.releaseStatuses,
+        }
       });
     },
     replayAction: (releaseId: number, actionId: number) => appClient.Post(

diff --git a/web/src/types/Release.d.ts b/web/src/types/Release.d.ts
@@ -68,3 +68,9 @@ interface ReleaseFilter {
   id: string;
   value: string;
 }
+
+interface DeleteParams {
+  olderThan?: number;
+  indexers?: string[];
+  releaseStatuses?: string[];
+}