fix: empty tmpFile var passed to download client's action #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludviglundgren
approved these changes
Feb 7, 2022
There was a problem hiding this comment.
Thank you for debugging and fixing this yourself! I haven't seen this issue before but always good to do an additional check so I'll merge this :)
Fixes #119
ghost
pushed a commit
that referenced
this pull request
Mar 1, 2022
Co-authored-by: zmiguel <contact@zmiguel.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #119
After some debugging I figured out that when
release.TorrentTmpFilewas not empty thetmpFilevariable would not be set.Resulting in sending an empty variable to the download client's action function. That ultimately resulted in a file not found error when trying to send the torrent file to the download client.
Fixed by adding an else condition setting
tmpFiletorelease.TorrentTmpFile(when it is not empty).Even though this only happened to me on deluge, I added the else condition to all instances where this could possibly happen.
edit: I've tested it by building the container and deluge is now correctly getting the torrent added