Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(notifications): Pushover and Telegram formatting #1362

Merged
merged 4 commits into from
Jan 23, 2024
Merged

fix(notifications): Pushover and Telegram formatting #1362

merged 4 commits into from
Jan 23, 2024

Conversation

zze0s
Copy link
Collaborator

@zze0s zze0s commented Jan 21, 2024

Fixes a regression that removed the html attributes for Pushover and Telegram notifications.

@zze0s zze0s added this to the v1.36.0 milestone Jan 21, 2024
vincejv
vincejv approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@vincejv vincejv left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
works great!
What I could suggest is to update the mock test notification to include escaped characters so it gets caught when there's a regression, but up to you. LGTM already.

internal/notification/message_builder.go Outdated Show resolved Hide resolved
@zze0s zze0s merged commit ae44271 into develop Jan 23, 2024
19 checks passed
@zze0s zze0s deleted the fix/notifications-formatting branch January 23, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincejv vincejv vincejv approved these changes

Assignees
No one assigned
Labels
backend Backend notifications
Projects
Project
Status: Done
Milestone
v1.36.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zze0s @vincejv