Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web): releases page search and filtering #1364

Merged
merged 3 commits into from
Jan 24, 2024
Merged

fix(web): releases page search and filtering #1364

merged 3 commits into from
Jan 24, 2024

Conversation

zze0s
Copy link
Collaborator

@zze0s zze0s commented Jan 21, 2024

Fix for the search and filtering on Releases page.

@zze0s zze0s added bug Something isn't working web releases labels Jan 21, 2024
@zze0s zze0s added this to the v1.36.0 milestone Jan 21, 2024
@martylukyy
Copy link
Collaborator

I think we should gotoPage(0) not only on PAGE_SIZE_CHANGED but also on FILTER_CHANGED...
That way the user doesn't end up with an empty page if he is further down the pages...
Opinions?

@zze0s
Copy link
Collaborator Author

zze0s commented Jan 21, 2024

I think we should gotoPage(0) not only on PAGE_SIZE_CHANGED but also on FILTER_CHANGED... That way the user doesn't end up with an empty page if he is further down the pages... Opinions?

Good call!! Fixed!

@zze0s
feat(releases): useQuery instead of useSuspenseQuery
612e0da 
useSuspenseQuery triggers a full loader that resets filters. useQuery does not.
@zze0s
Copy link
Collaborator Author

zze0s commented Jan 23, 2024

Would be great of someone could test this with a decent amount of releases in their db.

Changed from useSuspenseQuery to regular useQuery so that the page Suspense spinner isn't triggered. This should keep the state etc.

s0up4200
s0up4200 approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@s0up4200 s0up4200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on SQLite db with 13k releases. LGTM!

@zze0s zze0s merged commit dea0b32 into develop Jan 24, 2024
19 checks passed
@zze0s zze0s deleted the fix/releases-list-search-and-filtering branch January 24, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s0up4200 s0up4200 s0up4200 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working releases web
Projects
Project
Status: Done
Milestone
v1.36.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zze0s @martylukyy @s0up4200