feat(feeds): improve RSS size parsing #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zze0s
changed the title
zze0s
changed the title
zze0s
reviewed
Jan 27, 2024
internal/feed/rss_test.go
Outdated
Comment on lines
296
to
333
| func parseSize(sizeStr string) (uint64, error) { | ||
| var multiplier uint64 = 1 | ||
| sizeStr = strings.TrimSpace(sizeStr) | ||
|
|
||
| switch { | ||
| case strings.HasSuffix(sizeStr, "PiB"): | ||
| multiplier = 1024 * 1024 * 1024 * 1024 * 1024 | ||
| sizeStr = strings.TrimSuffix(sizeStr, "PiB") | ||
| case strings.HasSuffix(sizeStr, "TiB"): | ||
| multiplier = 1024 * 1024 * 1024 * 1024 | ||
| sizeStr = strings.TrimSuffix(sizeStr, "TiB") | ||
| case strings.HasSuffix(sizeStr, "GiB"): | ||
| multiplier = 1024 * 1024 * 1024 | ||
| sizeStr = strings.TrimSuffix(sizeStr, "GiB") | ||
| case strings.HasSuffix(sizeStr, "MiB"): | ||
| multiplier = 1024 * 1024 | ||
| sizeStr = strings.TrimSuffix(sizeStr, "MiB") | ||
| case strings.HasSuffix(sizeStr, "PB"): | ||
| multiplier = 1000 * 1000 * 1000 * 1000 * 1000 | ||
| sizeStr = strings.TrimSuffix(sizeStr, "PB") | ||
| case strings.HasSuffix(sizeStr, "TB"): | ||
| multiplier = 1000 * 1000 * 1000 * 1000 | ||
| sizeStr = strings.TrimSuffix(sizeStr, "TB") | ||
| case strings.HasSuffix(sizeStr, "GB"): | ||
| multiplier = 1000 * 1000 * 1000 | ||
| sizeStr = strings.TrimSuffix(sizeStr, "GB") | ||
| case strings.HasSuffix(sizeStr, "B"): | ||
| sizeStr = strings.TrimSuffix(sizeStr, "B") | ||
| } | ||
|
|
||
| sizeStr = strings.Replace(sizeStr, " ", "", -1) // Remove any spaces | ||
| size, err := strconv.ParseFloat(sizeStr, 64) | ||
| if err != nil { | ||
| return 0, fmt.Errorf("failed to parse size: %v", err) | ||
| } | ||
|
|
||
| return uint64(size * float64(multiplier)), nil | ||
| } |
There was a problem hiding this comment.
Good effort, but humanize.ParseBytes(str) does this already.
internal/feed/rss.go
Outdated
| if matches == nil { | ||
| return "" | ||
| // pullSizeFromDescription get size from description | ||
| func pullSizeFromDescription(str string, r *domain.Release) { |
There was a problem hiding this comment.
Minor nitpick but I think the old name readSizeFromDescription is better, or parse instead of read. we don't use the pull terminology anywhere else.
zze0s
approved these changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.