Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filters): RED and OPS lossless parsing and filtering #1373

Merged
merged 8 commits into from
Jan 28, 2024

Conversation

zze0s
Copy link
Collaborator

@zze0s zze0s commented Jan 24, 2024

Fix and improve filtering and parsing for RED and OPS.

Fixes #1001
Fixes #746
Fixes #851

@zze0s zze0s added bug Something isn't working backend Backend indexers irc filters Filters releases definitions Indexer definitions labels Jan 24, 2024
s0up4200
s0up4200 previously approved these changes Jan 25, 2024
Copy link
Collaborator

@s0up4200 s0up4200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filtered for EP, 24bit FLAC and log score. All reject and accept as expected 👍

19:38:57DBG(log score) for release: Banjo Kyle - Anime Life Lofi Vol. 2 [2024] (FLAC Lossless WEB) rejections: (release type not matching. got: Album want: [EP], quality not matching. got: [FLAC Lossless] want: [24bit Lossless], wanted: log, log score. got: 0 want: 100) method=CheckFilter module=filter

internal/domain/irc.go Fixed Show fixed Hide fixed
internal/domain/irc.go Dismissed Show dismissed Hide dismissed
Copy link
Collaborator

@s0up4200 s0up4200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with OPS and works there as well.
Note: OPS do not announce log scores. So Perfect FLAC will not work with OPS.

21:30:02INFMatched 'Kyles Banjo Orchestra - Now You Know [2024] (WEB FLAC 24BIT Lossless)' (24bit) for ops filter=24bit indexer=ops module=release release="Kyles Banjo Orchestra - Now You Know [2024] (WEB FLAC 24BIT Lossless)"

21:50:02TRCannounce: process line: TORRENT: Kyles Banjo Orchestra – Rednecks Like Me – [2023] [EP] WEB/FLAC/Lossless – country – https://orpheus.network/torrents.php?id=1234 – https://orpheus.1234action=download module=announce_processor network=irc.orpheus.network

21:50:02INFMatched Kyles Banjo Orchestra - Rednecks Like Me [2023] (WEB FLAC Lossless) (EP) for ops filter=EP indexer=ops module=release release="Kyles Banjo Orchestra - Rednecks Like Me [2023] (WEB FLAC Lossless)"

@zze0s zze0s merged commit 5328078 into develop Jan 28, 2024
19 checks passed
@zze0s zze0s deleted the fix/indexers-red-ops-lossless-parsing-filtering branch January 28, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Backend bug Something isn't working definitions Indexer definitions filters Filters indexers irc releases
Projects
Status: Done
2 participants