Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(filters): export not working with Safari #1505

Merged
merged 3 commits into from
Apr 25, 2024
Merged

fix(filters): export not working with Safari #1505

merged 3 commits into from
Apr 25, 2024

Conversation

zze0s
Copy link
Collaborator

@zze0s zze0s commented Apr 12, 2024

Fixes an issue where filters could not be exported with Safari.

Fixes #1487

@zze0s zze0s added bug Something isn't working web filters Filters external bug Bug from external project or library etc labels Apr 12, 2024
@zze0s zze0s modified the milestone: v1.41.0 Apr 12, 2024
s0up4200
s0up4200 approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@s0up4200 s0up4200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Safari on both latest iOS and MacOS. Both works.

@s0up4200 s0up4200 added this to the v1.42.0 milestone Apr 25, 2024
@zze0s zze0s merged commit d558db2 into develop Apr 25, 2024
19 checks passed
@zze0s zze0s deleted the fix/filters-export-with-safari branch April 25, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s0up4200 s0up4200 s0up4200 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working external bug Bug from external project or library etc filters Filters web
Projects
Project
Status: Done
Milestone
v1.42.0
Development

Successfully merging this pull request may close these issues.

[BUG] Export JSON does not work in Safari
2 participants
@zze0s @s0up4200