Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): mobile UI improvements #359

Merged
merged 2 commits into from
Jul 17, 2022
Merged

feat(web): mobile UI improvements #359

merged 2 commits into from
Jul 17, 2022

Conversation

ghost
Copy link

@ghost ghost commented Jul 17, 2022

enhancement: simplified and improved radio switch group look
fix: fixed inconsistent spacing in input components (there's still some work left to be done)
fix: made slideover panel display on full width on mobile devices
enhancement: made forms more accessible to mobile users, adapter changes in accordance with the previous input components fix
fix: fixed misspelling in NotificationForms filename
chore: cleaned up code
fix: made filter table top edges less round and improved look
fix: fixed a bug where when a modal/slideover component was opened, a 1px white bar would be shown in one of the modal parent elements (for the fix see L89 in screens/settings/DownloadClient.tsx)
enhancement: improved responsiveness for irc network list

could probably use another round of testing both on dark/light theme and mobile/desktop, but I'm pretty confident I didn't miss much, or anything for that matter

anonymous added 2 commits July 17, 2022 22:51
enhancement: simplified and improved radio switch group look
fix: fixed inconsistent spacing in input components (there's still some work left to be done)
fix: made slideover panel display on full width on mobile devices
enhancement: made forms more accessible to mobile users, adapter changes in accordance with the previous input components fix
fix: fixed misspelling in NotificationForms filename
chore: cleaned up code
fix: made filter table top edges less round and improved look
fix: fixed a bug where when a modal/slideover component was opened, a 1px white bar would be shown in one of the modal parent elements (for the fix see L89 in screens/settings/DwonloadClient.tsx)
enhancement: improved responsiveness for irc network list
@ghost ghost added enhancement New feature or request web labels Jul 17, 2022
@ghost ghost requested a review from ludviglundgren July 17, 2022 21:05
@ghost ghost mentioned this pull request Jul 17, 2022
@ludviglundgren ludviglundgren changed the title fix/enhancement: mobile UI improvements fix(web): mobile UI improvements Jul 17, 2022
@ludviglundgren ludviglundgren changed the title fix(web): mobile UI improvements feat(web): mobile UI improvements Jul 17, 2022
Copy link
Contributor

@ludviglundgren ludviglundgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots done 😄 LGTM!

@ludviglundgren ludviglundgren merged commit 3da594e into develop Jul 17, 2022
@ludviglundgren ludviglundgren deleted the fix/mobile-ui branch July 17, 2022 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant