fix(filters): max downloads per hour check #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the check for download per
HOURon SQLite.The solution is quite obvious now, but wasn't at the time.
timestamp >= strftime('%Y-%m-%dT%H:00:00Z', datetime('now','localtime')).That basically transforms the current time into a fixed format, and set's the current hour
%Hto the current hour from datetime, in local timezone, and then hardcodes minute and seconds to 00:00. So no more rolling hour, and there shouldn't be any bugs with it letting through more than set.Day, week, month and total has been working fine all the time.
Fixes #467 #455