Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Kite to autocomplete-python #250

Merged
merged 67 commits into from Dec 1, 2016
Merged

Adds Kite to autocomplete-python #250

merged 67 commits into from Dec 1, 2016

Conversation

itsdhung
Copy link
Contributor

@itsdhung itsdhung commented Dec 1, 2016

  • adds kite-installer to manage Kite.app and kite.js atom plugin
  • adds install page to let user choose between Kite and Jedi
  • if user chooses kite.js, then he'll be prompted to run Kite.app if it isn't running (e.g. shuts down computer and forgets to start it up)
  • other than that, there are no other functionality changes

@itsdhung itsdhung merged commit 39d7389 into autocomplete-python:master Dec 1, 2016
@sadovnychyi
Copy link
Member

Any reason why activationHooks were removed from package.json?

@itsdhung
Copy link
Contributor Author

itsdhung commented Dec 2, 2016

yeah unfortunately we need to get the install page open once the user installs the package, not when the user opens a python file. afaik there isn't a hook that's called on installation

@ghost
Copy link

ghost commented Jul 26, 2017

Why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants