Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Baking does not handle space transform nodes which are part of a nodedef #1245

Open
bernardkwok opened this issue Jun 23, 2021 · 0 comments
Open

Baking does not handle space transform nodes which are part of a nodedef #1245

bernardkwok opened this issue Jun 23, 2021 · 0 comments
Labels
Defect Defect fix Rendering Render change required
Projects
Develop
Milestone
1.38.4

Comments

@bernardkwok
Copy link

When baking a given node, if that node has a graph implementation which includes any kind of "space" transformation
it is not detected and the bakeed image can connect to the downstream input but not preserve the "space" transformation.

One notable example is a normalmap node. If connected in a upstream graph then this will work (if it's the first node for now).
If the upstream node is a nodegraph using a normalmap then it is not detected.

The logic is to preserve the transform node and bake upstream from it.
@bernardkwok bernardkwok added Defect Defect fix Rendering Render change required labels Jun 23, 2021
@bernardkwok bernardkwok added this to the 1.39 milestone Jun 23, 2021
@bernardkwok bernardkwok added this to To do in Develop via automation Jun 23, 2021
@bernardkwok bernardkwok mentioned this issue Jun 24, 2021
Merged
@bernardkwok bernardkwok modified the milestones: 1.39, 1.38.2 Jun 24, 2021
@bernardkwok bernardkwok modified the milestones: 1.38.2, 1.38.3 Sep 17, 2021
@kwokcb kwokcb modified the milestones: 1.38.3, 1.38.4 Dec 7, 2021
jstone-lucasfilm pushed a commit that referenced this issue Jan 30, 2024
@ld-kerley
Always build GLFW as a static library (AcademySoftwareFoundation#1680)
8828578 
Currently the embedded glfw build for MaterialXGraphEditor inherits the value of BUILD_SHARED_LIBS from MATERIALX_BUILD_SHARED_LIBS, but we're not installing libglfw, per #1245 the intention was to statically link.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Defect Defect fix Rendering Render change required
Projects
Develop
  
To do
Milestone
1.38.4
Development

No branches or pull requests
2 participants
@bernardkwok @kwokcb