Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance issue: When hovering any row triggers headerRenderer and cellRenderer for each column. #8

Closed
johnpittman opened this issue Apr 25, 2019 · 2 comments · Fixed by #9
Closed

Performance issue: When hovering any row triggers headerRenderer and cellRenderer for each column. #8

johnpittman opened this issue Apr 25, 2019 · 2 comments · Fixed by #9
Assignees
@nihgwu
Labels
enhancement New feature or request

Comments

@johnpittman
Copy link

When hovering any row triggers headerRenderer and cellRenderer for each column.

Test:
put console.log in inside the callbacks and move mouse around.
@nihgwu
Copy link
Contributor

nihgwu commented Apr 26, 2019 •
edited

Does that impact the performance heavily and is a bottle neck for you? I did it on purpose as I noticed some bugs if I make the TableHeaderRow a pure component, like with selection, the checkbox won’t update it’s state when selection state changes, I have to find a solution for that before I make it a pure component, thank you for reminding me that

@nihgwu nihgwu added the enhancement New feature or request label Apr 26, 2019
@nihgwu nihgwu self-assigned this Apr 26, 2019
@nihgwu
Copy link
Contributor

nihgwu commented Apr 26, 2019

Aha, it's another problem, fixing it

@nihgwu nihgwu mentioned this issue Apr 26, 2019
Merged
@nihgwu nihgwu closed this as completed in #9 Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nihgwu nihgwu

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

stop using forceUpdate Autodesk/react-base-table
2 participants
@nihgwu @johnpittman