Added T cast operator to Real #193
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had tested autodiff only as a header only-library and wasn't aware of the compile errors. Unsure if the fixes to min and max are correct. |
PaulXiCao
suggested changes
Dec 23, 2022
…rdingly." This reverts commit 8da0584.
…to feature/DoubleCast
PaulXiCao
reviewed
Dec 28, 2022
…ator by adding constexpr and removing static_cast.
mattarroz
commented
Dec 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cast operator is needed to make
std::isfinitework onReal, as discussed in #191. In consequence, it is now possible to compute derivatives for Eigenvalue/vector computations.