Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update build for RC1 #697

Closed
shawnwildermuth opened this issue Nov 18, 2015 · 19 comments
Closed

Update build for RC1 #697

shawnwildermuth opened this issue Nov 18, 2015 · 19 comments

Comments

@shawnwildermuth
Copy link

ASP.NET 5 RC1 is now strongly naming their assemblies. The dev branch needs to be rebuild using the full release (rc1-final) version of the libraries. I've tried to use the dev branch dailies from the MyGet feed, but they were built against RC before they were strongly named. Any chance of kicking off a new build?

@tillig
Copy link
Member

tillig commented Nov 18, 2015

We're doing what we can as fast as we can given, you know, it's not our "day job" :). I probably won't get to this today; @alexmg may have time.

We have an issue #594 where we're tracking the conversion effort for dnx. I'll close this so we don't track the same stuff in two places.

@tillig tillig closed this as completed Nov 18, 2015
@tillig
Copy link
Member

tillig commented Nov 18, 2015

(Of course, if you send us a PR on the dev branch with the required updates, I'll totally take it.)

@shawnwildermuth
Copy link
Author

The thing is that it doesn't require a PR, it's just a new kickoff of the CI build as works with the RC1 it just didn't build against the RC1-final because they hadn't strongly named them yet.

@shawnwildermuth
Copy link
Author

Sorry to make it sound urgent, just wanted to alert you to the issue with strong names.

@tillig
Copy link
Member

tillig commented Nov 18, 2015

Looks like it's going to take more than just a new build. I kicked off a new build of the previously passing code and now there's a ton of NuGet errors like

NU1002: The dependency System.Collections 4.0.11-beta-23516 in project Autofac does not support framework .NETPlatform,Version=v5.0

I'm guessing we also need to update the runtime in global.json to handle some things. Updating for dnx changes has never been straightforward. 😦

@dealdiane
Copy link

@tillig You need to change the TFMs to the new one. I hope it's as simple as that. aspnet/Announcements#98

@tillig
Copy link
Member

tillig commented Nov 18, 2015

Check out the develop branch. We already did that.

@dealdiane
Copy link

You still have net45 though. Some packages have been bumped up to net451.

Edit: just cloning that branch now..

@tillig
Copy link
Member

tillig commented Nov 18, 2015

Look at the errors - the net45 build works fine, it's the dotnet5.2 build that's failing. (It builds in the order of frameworks specified in project.json.)

@dealdiane
Copy link

Interesting looks like a simple nuget dependency problem? Can you clear the cache dnu clear-http-cache or kick another build? FYI, this builds fine locally.

Unable to resolve dependency System.Collections.Concurrent 4.0.11-beta-23516
Unable to resolve dependency System.ComponentModel 4.0.1-beta-23516
Unable to resolve dependency System.Diagnostics.Contracts 4.0.1-beta-23516

@alexmg
Copy link
Member

alexmg commented Nov 18, 2015

I had to update some of the dependencies when I did an earlier test of RC1. Would be nice to move purely to generations now though previously this was described as an experimental feature. Anyone known if it got the official go ahead?

@tillig
Copy link
Member

tillig commented Nov 18, 2015

Hang on, this may be my bad - I rebuilt master, not develop... trying again. Too much going on at once today. (Of course, I'm not sure why master wouldn't build anymore, but I guess that's a whole other issue.)

@tillig
Copy link
Member

tillig commented Nov 18, 2015

Generations are still in progress since the tooling isn't there. dotnet5.2 is supposed to work with .NET 4.5 but the tooling's not done so NuGet still sees it as incompatible. They added a link to the work item for tracking on the announcement for generations.

@dealdiane
Copy link

Test failing. Does it still generate an artifact or does it require all green on all tests?

@tillig
Copy link
Member

tillig commented Nov 18, 2015

OK, building develop fails for xunit reasons. It at least passes the dotnet5.2 problem, so that one's on me. 💩 But it's still not as simple as a rebuild.

I'm out on this one until at least tomorrow.

@dealdiane
Copy link

Switching sdks from rc1-16048 to rc1-final will fix it. Running test.cmd will load the packages from the %userprofile%\.dnx\runtimes directory first not from the \packages directory and because the libraries in rc1-16048 are not signed it throws the error.

@shawnwildermuth
Copy link
Author

I've added PR# 698 though I am not sure about how helpful it is. If it isn't, feel free to dump it since I didn't realize you guys were still working on it.

@tillig
Copy link
Member

tillig commented Nov 19, 2015

Published Autofac and Autofac.Extensions.DependencyInjection 4.0.0-rc1-177 to NuGet with ASP.NET 5 RC1 compatibility.

@shawnwildermuth
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants