Fix memory leak regression #1353
Merged
+18
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncurrentBag for registrations by ensuring we empty the bag when we're done with it.
Codecov ReportBase: 77.98% // Head: 77.96% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1353 +/- ##
===========================================
- Coverage 77.98% 77.96% -0.03%
===========================================
Files 195 195
Lines 5587 5590 +3
Branches 1119 1119
===========================================
+ Hits 4357 4358 +1
- Misses 716 717 +1
- Partials 514 515 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
alistairjevans
approved these changes
Oct 25, 2022
|
@alistairjevans Sure. Is it possible to make a new release with this fix? |
|
This seems to have a drastic effect combined with autofac/Autofac.Owin#29: I am investigating a very sizeable memory leak after upgrading to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix memory leak due to use of ConcurrentBag for registrations by ensuring we empty the bag when we're done with it.
Bug was fixed in #1257
AsyncDispose was not aware of this issue.