Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix syntax error in type annotation #2376

Merged
merged 4 commits into from
Jan 4, 2023

Conversation

daikikatsuragawa
Copy link
Contributor

Signed-off-by: Daiki Katsuragawa 50144563+daikikatsuragawa@users.noreply.github.com

When I executed the following command ...

mypy --ignore-missing-imports --warn-unreachable core/

The following error was detected.

core/src/autogluon/core/utils/utils.py:368: error: Syntax error in type annotation  [syntax]

When a function returns more than one value, the values are represented as tuples.

Signed-off-by: Daiki Katsuragawa <50144563+daikikatsuragawa@users.noreply.github.com>
@daikikatsuragawa
Copy link
Contributor Author

For example, I get the following error with the following task.

https://github.com/awslabs/autogluon/actions/runs/3455985811/jobs/5768417443

Error: 🚨 Insuffient Permissions! daikikatsuragawa does not have write permissions

What should I do?

Copy link
Collaborator

@yinweisu yinweisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. We probably won't merge this in right now as we are in code freeze for 0.6 release

core/src/autogluon/core/utils/utils.py Outdated Show resolved Hide resolved
@Innixma Innixma added this to the 0.7 Release milestone Nov 14, 2022
@daikikatsuragawa
Copy link
Contributor Author

Merge branch 'master' into master

This is a response to conflicts.

@github-actions
Copy link

Job PR-2376-4712ca0 is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2376/4712ca0/index.html

@github-actions
Copy link

Job PR-2376-bb85eae is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2376/bb85eae/index.html

Copy link
Contributor

@Innixma Innixma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@Innixma Innixma merged commit ce98fd7 into autogluon:master Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants