Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Post 0.6][Tabular] Speed up feature transform in tabular NN model #2442

Merged
merged 2 commits into from
Nov 23, 2022

Conversation

liangfu
Copy link
Collaborator

@liangfu liangfu commented Nov 18, 2022

Description of changes:

This PR simplifies the feature transform function in tabular NN model.

  1. avoid using string-based processing
  2. leverage numpy.isin(b, a, invert=True) function instead of running np.array([item in b for item in a])

Benchmark results are shown below
image

image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions
Copy link

Job PR-2442-25f53bd is done.
Docs are uploaded to http://autogluon-staging.s3-website-us-west-2.amazonaws.com/PR-2442/25f53bd/index.html

@liangfu
Copy link
Collaborator Author

liangfu commented Nov 21, 2022

cc @tonyhoo @Innixma

Copy link
Contributor

@Innixma Innixma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, I see an even bigger speed up of around 40% using m6i.16xlarge in my testing!

@Innixma Innixma merged commit 9891afd into autogluon:master Nov 23, 2022
@liangfu liangfu deleted the transform-1 branch November 23, 2022 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants